Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom nonce for transactions #19705

Closed
jamesmudgett opened this issue Nov 24, 2021 · 2 comments · Fixed by brave/brave-core#11840
Closed

Set custom nonce for transactions #19705

jamesmudgett opened this issue Nov 24, 2021 · 2 comments · Fixed by brave/brave-core#11840
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@jamesmudgett
Copy link

Allow advanced setting of nonce for transactions. Expose a settings icon on send confirmation panel to set custom nonce.
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 24, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 26, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 21, 2021
@bbondy bbondy mentioned this issue Jan 1, 2022
Closed
@onyb onyb mentioned this issue Jan 13, 2022
Merged
25 tasks
@onyb onyb self-assigned this Jan 14, 2022
@onyb onyb added this to the 1.36.x - Nightly milestone Jan 15, 2022
@srirambv srirambv mentioned this issue Feb 4, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Brave 1.36.83 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11840
  • Verified settings option is shown on transaction details view
  • Verified clicking on the gear icon opens nonce page
  • Verified info text is shown below the nonce input field and doesn't have a pre-populated value
  • Verified input nonce value is set and doesn't clear when closed
19705-Linux.mp4
19705-Windows.mov
19705-macOS.mov

@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Android specific issue logged #20887. Removing Android label

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Feb 4, 2022
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): allow setting custom nonce in transaction panel brave/brave-core
4 participants
@jamesmudgett @bbondy @onyb @srirambv