Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom nonce for transactions #20887

Closed
srirambv opened this issue Feb 4, 2022 · 2 comments · Fixed by brave/brave-core#12584
Closed

Set custom nonce for transactions #20887

srirambv opened this issue Feb 4, 2022 · 2 comments · Fixed by brave/brave-core#12584
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Android version of #19705

Allow advanced setting of nonce for transactions. Expose a settings icon on send confirmation panel to set custom nonce.

cc: @SergeyZhukovsky @wchen342 @Pavneet-Sing
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 4, 2022
@srirambv srirambv mentioned this issue Feb 4, 2022
Closed
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 7, 2022
@bbondy bbondy added this to Web3 Mar 16, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 16, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 11, 2022
Merged
25 tasks
@Pavneet-Sing
Copy link

Closing this as this has been resolved by PR #12584

Repository owner moved this from Backlog to Done in Web3 Apr 11, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Apr 11, 2022
@kjozwiak kjozwiak mentioned this issue Apr 27, 2022
Closed
@srirambv
Copy link
Contributor Author

Verification passed as part of #21459 (comment). Removing Release notes label as this is pretty much same as #21459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): customize nonce in transaction panel brave/brave-core
3 participants
@bbondy @Pavneet-Sing @srirambv