Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex Maps not showing properly due to Ad blocking #1984

Closed
eljuno opened this issue Nov 4, 2018 · 7 comments
Closed

Yandex Maps not showing properly due to Ad blocking #1984

eljuno opened this issue Nov 4, 2018 · 7 comments
Labels
priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/shields Shields is breaking a website.

Comments

@eljuno
Copy link

eljuno commented Nov 4, 2018

Description

Originally reported on Community https://community.brave.com/t/can-not-show-in-brave-browser-yandex-ru-maps/36555?u=eljuno

Yandex Maps is not showing properly. Likely the resources is blocked by Brave's ads and tracker blocker. Brave should display it properly with default shields settings.

Steps to Reproduce

  1. Open Yandex Maps https://yandex.ru/maps
  2. The maps is not showing
  3. Open per site shields settings, change to Allow ads and tracking
  4. Map is show properly

Actual result:

image

Expected result:

image

Reproduces how often:

Easy.

Brave version (brave://version info)

Brave Version(about:brave): 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Reproduced on 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit) Win8.1 x64

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?

Changed to Allow ads and tracking show the maps

  • Is the issue reproducible on the latest version of Chrome?

NDA

Additional Information

@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@tildelowengrimm tildelowengrimm added webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Nov 5, 2018
@tildelowengrimm tildelowengrimm added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 7, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 12, 2018

Nytimes videos are not playing due to Ad blockers issue on Version 0.56.12

nytimes_adblockers issue

@srirambv
Copy link
Contributor

This needs to be moved to a proper milestone. @iefremov could you link the brave-core or any other brave repo PR that fixes it and move the issue to appropriate milestone where the fix has landed.

@iefremov
Copy link
Contributor

@srirambv Sorry, but its hard to determine the milestone, since the issue was fixed in a 3rdparty repo that provides an ad-blocking list for us.

It was fixed here https://github.com/mozilla-services/shavar-prod-lists/pull/42/files#diff-005fd85a9f635cd2580b842685143653L5763

@srirambv
Copy link
Contributor

cc: @bbondy to add the issue to milestone as this would need to be QA'd

@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Release Feb 1, 2019
@bbondy
Copy link
Member

bbondy commented Feb 1, 2019

@srirambv I put it in 0.59.x. For cases like this just put it in the closest to release milestone.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2019

Verification PASSED with macOS 10.14.2 x64 using the following build:

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Verification passed on

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 7

image

Verification passed on Ubuntu 17.10

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/shields Shields is breaking a website.
Projects
None yet
Development

No branches or pull requests

8 participants