Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video playback fails until adblock is toggled #902

Closed
7 tasks done
srirambv opened this issue Aug 31, 2018 · 17 comments
Closed
7 tasks done

Video playback fails until adblock is toggled #902

srirambv opened this issue Aug 31, 2018 · 17 comments
Assignees
Labels
closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. site-bug webcompat/shields Shields is breaking a website. workaround/allow-ads-and-tracking

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 31, 2018

Issue ported over from brave/browser-laptop#8521

Sites on which video playback fails with adblock

@pes10k
Copy link
Contributor

pes10k commented Oct 1, 2018

I cannot recreate the following sites in the beta

@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2018

This is surprising. IMDB and ESPN is allowing playback without having to disable shields/toggle adblock. Was there anything changed on the adblock library?

@Techguyprivate
Copy link

Techguyprivate commented Oct 11, 2018

brave
Weird behaviour. I am sending you a gif ,please look at it.

  1. I have disabled script blocking in Brave default shield in chrome://setting.

  2. In chrome://setting , go to content setting ,then javascript toggle option showing disabled.

3 .Also, there is no toggle button in all site content setting.

  1. I have to enable javascript on every site manually through the brave shield right of url bar.

  2. Then it showed of in javascript setting in chrome:// setting , content setting as allowed.

Same thing also in both brave dev and beta built on brave core ( not brave browser laptop built on muon,modifeid electron)

@bbondy bbondy added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Oct 25, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 25, 2018

  • https://abcnews.go.com. Adblock blocks frame script which contains valid origins to load video. Toggle adblock loads the video correctly
    image
    image

@tildelowengrimm tildelowengrimm added webcompat/shields Shields is breaking a website. priority/P3 The next thing for us to work on. It'll ride the trains. and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Nov 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@dead-claudia
Copy link

BTW, I'll note I do get PornHub playback (including PornHub Live) in Chrome + uMatrix with these rules, but with a few caveats:

  • I do get their fake popup ads (they open a new tab to destination, focus on that tab, then set existing tab to an ad without focusing) when I click "Porn Videos".
  • I get the TrafficJunky ad placeholders, even though no ads are actually loaded.
  • I so far haven't been able to get it to load without dropping the naiadsystems.com rules - those may need stubbed.
* * * block
* * css allow
* * frame block
* * image allow
* 1st-party * allow
* 1st-party frame allow
pornhub.com naiadsystems.com script allow
pornhub.com naiadsystems.com xhr allow
pornhub.com phncdn.com frame allow
pornhub.com phncdn.com media allow
pornhub.com phncdn.com script allow
pornhub.com pornhublive.com frame allow
pornhub.com pornhublive.com script allow
pornhub.com rncdn3.com media allow

@GeetaSarvadnya
Copy link

@ryanbr
Copy link

ryanbr commented May 18, 2019

Foxnews/Fox Business adblock annoyance:

@@||fncstatic.com/static/v/all/js/ads.js

@Brave-Matt
Copy link

User reporting fox news video play back issue:
https://community.brave.com/t/on-the-fox-news-website-videos-arent-playing/69496

@ryanbr
Copy link

ryanbr commented Jul 10, 2019

I thought foxnews this was fixed, okay this will need a bit to debug.

@Brave-Matt
Copy link

Another report of fox news videos not playing until sheilds are down/ads are allowed:
https://community.brave.com/t/videos-dont-play-from-fox-news/81622/3

@ryanbr
Copy link

ryanbr commented Sep 13, 2019

I've fixed abcnews, if someone can confirm?

Tested with https://abcnews.go.com/Entertainment/kim-kardashian-west-backlash-working-trump-choose-alice/story?id=65571704

And from the main page; https://abcnews.go.com/

Working on getting foxnews atm.

@ryanbr
Copy link

ryanbr commented Sep 16, 2019

Foxnews and Foxbusiness should work now

@bkarlan
Copy link

bkarlan commented Jul 29, 2020

Not working. I'm using Brave Version 1.11.101 Chromium: 84.0.4147.89 (Official Build) (64-bit)

@antonok-edm
Copy link
Collaborator

@ryanbr it looks to me like videos on foxbusiness articles are still broken

@kenherbert
Copy link

Issues with IMDB again (or still?). Videos try to play but immediately skip to next in the queue.

@ryanbr
Copy link

ryanbr commented Dec 13, 2020

Checking Foxnews/Fox Business is now working.

Regarding the Imdb issue @thefallofbecause : #13101

@ryanbr
Copy link

ryanbr commented Apr 21, 2021

Before closing ticket. reviewed the following sites and sample links.

With default shield settings, the following sites were checked for video playback and confirmed:

https://www.imdb.com/video/vi3657416729?ref_=hm_hp_i_1&listId=ls053181649 Worked.
https://www.espn.com/soccer/borussia-dortmund/story/4358642/bellingham-ready-to-succeed-haalandsancho-as-dortmunds-brightest-prospect Worked
https://video.foxnews.com/v/6249541545001#sp=show-clips Worked
https://www.foxbusiness.com/lifestyle/united-airlines-boeing-777-engine-pratt-whitney-resume-flying Worked
https://www.pornhub.com/view_video.php?viewkey=xxxxxx Worked
https://www.nytimes.com/video/us/politics/100000007721570/biden-george-floyd-verdict.html Worked
https://abcnews.go.com/Health/video/volunteers-launch-websites-people-access-covid-19-vaccines-76342641 Worked.

Any other issues with various sites, we should just log a issue report per site. cc: @srirambv

@ryanbr ryanbr closed this as completed Apr 21, 2021
@ryanbr ryanbr self-assigned this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. site-bug webcompat/shields Shields is breaking a website. workaround/allow-ads-and-tracking
Projects
None yet
Development

No branches or pull requests