Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey out extensions in Tor settings #4122

Closed
srirambv opened this issue Apr 16, 2019 · 2 comments
Closed

Grey out extensions in Tor settings #4122

srirambv opened this issue Apr 16, 2019 · 2 comments
Labels
feature/global-settings Settings at browser level independent of shields settings feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Although extensions are disabled internally, they show up as enabled in Tor settings. The extensions section needs to be removed completely or greyed out

Steps to Reproduce

  1. Open Tor window
  2. Open settings
  3. Extensions shows up as enabled even thoug they don't work on Tor Windows

Actual result:

image (1)

Expected result:

Remove the extension section or grey them out as disabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.62.51 Chromium: 73.0.3683.103 (Official Build) (64-bit)
Revision e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
OS All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

cc: @riastradh-brave

@srirambv srirambv added feature/tor feature/global-settings Settings at browser level independent of shields settings QA/Yes labels Apr 16, 2019
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label May 6, 2019
@yrliou
Copy link
Member

yrliou commented Oct 3, 2019

With brave/brave-core#3319 merged, this could be closed now since we will open the settings page in the parent profile (original regular window).

@yrliou yrliou closed this as completed Oct 3, 2019
@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 3, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Nov 13, 2019

Verification passed on

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Linux

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

5 participants