Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet HD path is wrong for legacy #19883

Closed
scmart opened this issue Dec 2, 2021 · 8 comments · Fixed by brave/brave-core#12314
Closed

Wallet HD path is wrong for legacy #19883

scmart opened this issue Dec 2, 2021 · 8 comments · Fixed by brave/brave-core#12314

Comments

@scmart
Copy link

scmart commented Dec 2, 2021

When connecting to a Ledger S hardware wallet, and using "Legacy (MEW/MyCrypto)", only the first address is correct.

Steps to Reproduce

  1. Connect Ledger Nano S
  2. Add Account
  3. Select Legacy (MEW/MyCrypto)

Actual result:

Addresses 2-5 (and probably beyond) are the wrong addresses.

Expected result:

Addresses 2-5 should match what MEW, MyCrypto, and metamask with the legacy option list.

Reproduces how often:

Always

Brave version (brave://version info)

Version 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Ubuntu 20.04

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the nightly channel? Unknown

Miscellaneous Information:

A minor note, the UI experience switching between Ledger Live and Legacy is bad. It reverts to the connect to HW wallet view, where I though I had to reclick connect, so I did, followed by an error, before it then snaps back to the address list.

@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 3, 2021
@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2021

cc: @onyb @darkdh

@scmart
Copy link
Author

scmart commented Jan 3, 2022

@srirambv Seems like this should be an easy and important fix. Hard to use the Brave wallet when most of my addresses aren't discoverable.

@scmart
Copy link
Author

scmart commented Feb 16, 2022

Still broken in Version 1.35.101

@spylogsster @srirambv @onyb @darkdh

@spylogsster spylogsster self-assigned this Feb 16, 2022
@spylogsster
Copy link

will take a look tomorrow, thanks @scmart for the reminder

@bbondy
Copy link
Member

bbondy commented Feb 17, 2022

Shouldn't we permanently have a third option now to have the other derivation path in case someone used those addresses and wants to get access again via a new import?

@spylogsster
Copy link

Shouldn't we permanently have a third option now to have the other derivation path in case someone used those addresses and wants to get access again via a new import?

follow-up issue #21171

@kjozwiak
Copy link
Member

This was originally uplifted/scheduled to go into a 1.35.x HF but never ended up being released. It will go out via 1.36.x as we won't be having another 1.35.x release at this point.

@srirambv
Copy link
Contributor

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified test plan from brave/brave-core#12314
  • Verified import accounts with Legacy derivation path from MM and Brave Wallet works
  • Verified imported accounts on both legacy and live are both same on MM and Brave Wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants