-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet HD path is wrong for legacy #19883
Comments
@srirambv Seems like this should be an easy and important fix. Hard to use the Brave wallet when most of my addresses aren't discoverable. |
Still broken in Version 1.35.101 |
will take a look tomorrow, thanks @scmart for the reminder |
Shouldn't we permanently have a third option now to have the other derivation path in case someone used those addresses and wants to get access again via a new import? |
follow-up issue #21171 |
This was originally uplifted/scheduled to go into a |
|
When connecting to a Ledger S hardware wallet, and using "Legacy (MEW/MyCrypto)", only the first address is correct.
Steps to Reproduce
Actual result:
Addresses 2-5 (and probably beyond) are the wrong addresses.
Expected result:
Addresses 2-5 should match what MEW, MyCrypto, and metamask with the legacy option list.
Reproduces how often:
Always
Brave version (brave://version info)
Version 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Ubuntu 20.04
Miscellaneous Information:
A minor note, the UI experience switching between Ledger Live and Legacy is bad. It reverts to the connect to HW wallet view, where I though I had to reclick connect, so I did, followed by an error, before it then snaps back to the address list.
The text was updated successfully, but these errors were encountered: