Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong legacy derivation path #12314

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix wrong legacy derivation path #12314

merged 1 commit into from
Feb 17, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 17, 2022

Resolves brave/brave-browser#19883

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Import accounts with Legacy derivation path from MM and Brave Wallet
  • Accounts should have same addresses

@spylogsster spylogsster self-assigned this Feb 17, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 17, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit 24f3bdd into master Feb 17, 2022
@spylogsster spylogsster deleted the brave-19883 branch February 17, 2022 13:35
@spylogsster spylogsster restored the brave-19883 branch February 17, 2022 13:35
brave-builds pushed a commit that referenced this pull request Feb 17, 2022
spylogsster added a commit that referenced this pull request Feb 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.37.58 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 11 Version Dev (Build 22543.1000)
  • Verified import accounts with Legacy derivation path from MM and Brave Wallet works
  • Verified imported accounts on both legacy and live are both same on MM and Brave Wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet HD path is wrong for legacy
4 participants