Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on Browser back button resets the newtab stats #2018

Closed
simonhong opened this issue Nov 6, 2018 · 3 comments
Closed

Click on Browser back button resets the newtab stats #2018

simonhong opened this issue Nov 6, 2018 · 3 comments
Assignees
@simonhong
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@simonhong
Copy link
Member

simonhong commented Nov 6, 2018 •
edited
Loading

Description

Click on Browser back button resets the newtab stats

Steps to Reproduce

  1. Launch browser and open newtab and check stats are properly visible
  2. Go to www.google.com from newtab by typing it in omnibox
  3. Press backbutton to go newtab again

Actual result:

All newtab stats are zero

Expected result:

stats should not be all zero

Reproduces how often:

Easily

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

I think the cause of #1490 is related with this.
chrome://adblock/ also has same issue.
@simonhong simonhong self-assigned this Nov 6, 2018
@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2018

dupe of #307

@srirambv srirambv closed this as completed Nov 6, 2018
@srirambv srirambv added the closed/duplicate Issue has already been reported label Nov 6, 2018
@srirambv srirambv added this to the Dupe / Invalid / Not actionable milestone Nov 6, 2018
@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2018

@simonhong assigned #307 to you

@simonhong
Copy link
Member Author

@srirambv Oops. we have one already. Thanks!
I'm working this this issue now

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @simonhong @srirambv