Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating back causes stats to reset on that tab #307

Closed
srirambv opened this issue Jun 8, 2018 · 8 comments · Fixed by brave/brave-core#826
Closed

Navigating back causes stats to reset on that tab #307

srirambv opened this issue Jun 8, 2018 · 8 comments · Fixed by brave/brave-core#826
Assignees
@simonhong
Labels
bug feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 8, 2018

Description

Navigating back causes stats to reset on that tab

Steps to Reproduce

  1. Build from source ( aa02380)
  2. Open a new tab and visit a site so that stats get updated
  3. Open a second tab and ensure the updated stats are shown
  4. Search/visit a new site in the second tab
  5. Click back button to go back to new tab, stats reset to 0, reload doesn't change
  6. Open a third tab, stats show correctly

Actual result:

privatetav

Expected result:

Navigating back shouldn't reset stats on the new tab page

Reproduces how often:

100%

Brave version (about:brave info)

aa02380

Additional Information

Same behaviour on both normal tabs and private tabs
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@srirambv
Copy link
Contributor Author

Issue looks fixed on master (3924de4)

@bbondy bbondy added the QA/Yes label Aug 17, 2018
@btlechowski
Copy link

Still reproducible, tested:

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

307_fail

@btlechowski btlechowski reopened this Sep 21, 2018
@kjozwiak
Copy link
Member

Reproducible under macOS 10.13.6 x64 using the same build @btlechowski mentioned above.

@srirambv
Copy link
Contributor Author

Broken on Linux as well for 0.55.5

@rebron rebron modified the milestones: Releasable builds 0.55.x, 1.0 Sep 25, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2018

+1 from https://community.brave.com/t/homepage-shows-0-for-all-stats-if-you-go-back/33755

@rebron rebron modified the milestones: 1.0 (0.56.x), 1.x Backlog Oct 2, 2018
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2018
@kjozwiak kjozwiak mentioned this issue Oct 11, 2018
Closed
@cndouglas
Copy link
Contributor

Still reproducible for me with Brave 0.57.3 on macOS 10.14.

@srirambv srirambv mentioned this issue Oct 27, 2018
Closed
@srirambv
Copy link
Contributor Author

+1 from @sillibird via #1865

@srirambv srirambv mentioned this issue Nov 6, 2018
Closed
@simonhong simonhong mentioned this issue Nov 7, 2018
Merged
18 tasks
@simonhong simonhong modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 7, 2018
@mbacchi mbacchi modified the milestones: 0.59.x - Nightly, 0.58.x - Dev Nov 8, 2018
@eljuno eljuno mentioned this issue Nov 21, 2018
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Dec 11, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Opened a site in a new tab
  • Checked stats on second newtab
  • Visited a different site in second newtab and navigated back, stats didnt get reset

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows
  • Verfied the STR from description

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR from description

@kjozwiak kjozwiak mentioned this issue Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix webui stats are empty when it loaded by navigation back brave/brave-core