Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inexact amounts in transaction confirmation screen #20432

Closed
onyb opened this issue Jan 11, 2022 · 1 comment · Fixed by brave/brave-core#11938
Closed

Inexact amounts in transaction confirmation screen #20432

onyb opened this issue Jan 11, 2022 · 1 comment · Fixed by brave/brave-core#11938
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@onyb
Copy link
Member

onyb commented Jan 11, 2022

Extracted out from #20264.

☠️ A critical bug as a result of storing amounts in native currency units. 👇

147694683-af6d408b-7fd4-46fe-9452-a29d5750d7be.mov
@onyb onyb added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 11, 2022
@onyb onyb self-assigned this Jan 11, 2022
@onyb onyb mentioned this issue Jan 20, 2022
Merged
25 tasks
@onyb onyb added this to the 1.36.x - Nightly milestone Jan 21, 2022
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11938
  • Verified input value is not truncated and shows the full value on the transaction confirmation screen

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Fix inexact amounts in transction confirmation screen brave/brave-core
2 participants
@onyb @srirambv