Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inexact amounts in transction confirmation screen #11938

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Jan 20, 2022

Motivation: We want users to sign exactly what they enter in amount fields. For this to happen, we must display unaltered amounts in the transaction confirmation screen (panel).

Summary of changes:

  • Refactored utils in format-prices.ts to use bignumber.js. Fiat values are always formatted to two places of decimals, unless less than 0.01. Crypto values are no longer formatted using the log stuff - my reasoning is that formatWithCommasAndDecimals is always passed values that are pre-formatted using utils in format-balances.ts, so we don't need another level of formatter. I still keep most of the logic as-is.
  • Added a valueExact field to transaction parser response, to be used in the transaction confirmation screen.

Resolves brave/brave-browser#20432.
Resolves brave/brave-browser#19521.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Here are the transaction screens after creation a transaction with value 0.037314235731347379 ETH.

Before After

@onyb onyb self-assigned this Jan 20, 2022
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Jan 20, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@muliswilliam muliswilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inexact amounts in transaction confirmation screen Wallet - transfer of ERC-20 tokens rounded
4 participants