Fix inexact amounts in transction confirmation screen #11938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: We want users to sign exactly what they enter in amount fields. For this to happen, we must display unaltered amounts in the transaction confirmation screen (panel).
Summary of changes:
format-prices.ts
to usebignumber.js
. Fiat values are always formatted to two places of decimals, unless less than0.01
. Crypto values are no longer formatted using the log stuff - my reasoning is thatformatWithCommasAndDecimals
is always passed values that are pre-formatted using utils informat-balances.ts
, so we don't need another level of formatter. I still keep most of the logic as-is.valueExact
field to transaction parser response, to be used in the transaction confirmation screen.Resolves brave/brave-browser#20432.
Resolves brave/brave-browser#19521.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Demo
Here are the transaction screens after creation a transaction with value
0.037314235731347379 ETH
.