Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FindX from list of search providers #2047

Closed
da2x opened this issue Nov 8, 2018 · 2 comments · Fixed by brave/brave-core#907
Closed

Remove FindX from list of search providers #2047

da2x opened this issue Nov 8, 2018 · 2 comments · Fixed by brave/brave-core#907
Assignees
@mkarolin
Labels
feature/search priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@da2x
Copy link

da2x commented Nov 8, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#907

Original issue description

FindX is shutting down. Search already doesn't work.

It should be removed from the list of built-in search engines.
@bbondy bbondy mentioned this issue Nov 13, 2018
Closed
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 13, 2018
@mkarolin
Copy link
Contributor

For the upgrade scenario, if the engine was not set as the default it will get removed on upgrade. If, however, FindX was set as the default search engine, it wouldn't be removed on upgrade and will stay on the list until removed manually. Assuming it's not a concern since the engine has already been shut down, so most/all of those who had it set as the default would have changed to a different default by now.

mkarolin added a commit to brave/brave-core that referenced this issue Nov 14, 2018
@mkarolin
Fixes brave/brave-browser#2047
c56f375 
Removed FindX from default search engines.
Bumped up kBraveCurrentDataVersion to 2.
Updated unit tests to not reference the removed engine.
@mkarolin mkarolin mentioned this issue Nov 14, 2018
Merged
18 tasks
@bsclifton bsclifton added this to the 0.59.x - Nightly milestone Nov 16, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 19, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
89b5d3b 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 3, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
0ceac18 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 4, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
f54291c 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 5, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
5eb3868 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 5, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
d01837a 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 5, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
6ddb395 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 6, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
3ced621 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 7, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
8c157e8 
removed from brave-core with brave/brave-browser#2047
bsclifton added a commit to brave/browser-laptop that referenced this issue Dec 7, 2018
@bsclifton
Remove FindX search engine (I believe it's been EOLed). This was already
cf1d2b3 
removed from brave-core with brave/brave-browser#2047
@LaurenWags
Copy link
Member

LaurenWags commented Dec 21, 2018 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta(64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Mac OS X

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/search priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Remove FindX from search engines brave/brave-core
7 participants
@bbondy @da2x @bsclifton @rebron @LaurenWags @GeetaSarvadnya @mkarolin