Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up Wallet UI to use Chain Icons #20687

Closed
Douglashdaniel opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#12003
Closed

Wire up Wallet UI to use Chain Icons #20687

Douglashdaniel opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#12003
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@Douglashdaniel
Copy link

Description

Wire up the Wallet UI to use Chain Icons
Follow up to brave/brave-core#11966
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 25, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 25, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 26, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 27, 2022
@srirambv
Copy link
Contributor

Brave 1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified test plan from #20000
  • Verified Add token shows icon for the coin that is being added
  • Verified custom asset added shows the icon on visible asset list
20000-Linux.mp4
20000-Windows.mov
20000-macOS.mov

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Display Custom Chain and Token Icons brave/brave-core
2 participants
@srirambv @Douglashdaniel