Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Display Custom Chain and Token Icons #12003

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Jan 26, 2022

Description

Display Custom Chain and Token Icons in Wallet UI

  1. Adding a Icon URL to a custom network will now display that icon for the base asset.
  2. There is now a Icon URL field in the EditVisibleAssets modal under the Advanced section.
  3. Added an additional safety check to make sure that the URL ends with a valid icon extension (.png, .jpg, etc..)

Resolves brave/brave-browser#20687
Resolves brave/brave-browser#20000
Resolves brave/brave-browser#20256

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Custom Network Icon Demo:

Screen.Recording.2022-01-26.at.7.58.13.AM.mov

Custom Token Icon Demo:

Screen.Recording.2022-01-26.at.8.08.52.AM.mov

Adding a Custom Token from Coingecko:

Screen.Recording.2022-01-26.at.1.49.28.PM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 26, 2022 16:39
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 🚀

@onyb
Copy link
Member

onyb commented Jan 26, 2022

This also closes brave/brave-browser#20256.

@yrliou
Copy link
Member

yrliou commented Jan 26, 2022

I suppose this will also solve brave/brave-browser#20000?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel
Copy link
Contributor Author

Douglashdaniel commented Jan 26, 2022

I suppose this will also solve brave/brave-browser#20000?

Thanks for mentioning this, updated to work there too! 😎

@Douglashdaniel
Copy link
Contributor Author

This also closes brave/brave-browser#20256.

Maybe we should keep open for Android and IOS?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 27, 2022
@Douglashdaniel Douglashdaniel merged commit 7fa9274 into master Jan 27, 2022
@Douglashdaniel Douglashdaniel deleted the chain-icons-in-ui branch January 27, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wire up Wallet UI to use Chain Icons Make token icon URI used Support image param in wallet_watchAsset
4 participants