-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Display Custom Chain and Token Icons #12003
Conversation
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! 🚀
This also closes brave/brave-browser#20256. |
I suppose this will also solve brave/brave-browser#20000? |
A Storybook has been deployed to preview UI for the latest push |
a37b6f9
to
7c5b8c4
Compare
Thanks for mentioning this, updated to work there too! 😎 |
Maybe we should keep open for |
7c5b8c4
to
2f5d1df
Compare
2f5d1df
to
1ce0858
Compare
A Storybook has been deployed to preview UI for the latest push |
Description
Display Custom Chain and Token Icons in Wallet UI
Icon URL
to a custom network will now display that icon for the base asset.Icon URL
field in theEditVisibleAssets
modal under theAdvanced
section.URL
ends with a valid icon extension (.png, .jpg, etc..)Resolves brave/brave-browser#20687
Resolves brave/brave-browser#20000
Resolves brave/brave-browser#20256
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Custom Network Icon Demo:
Screen.Recording.2022-01-26.at.7.58.13.AM.mov
Custom Token Icon Demo:
Screen.Recording.2022-01-26.at.8.08.52.AM.mov
Adding a Custom Token from Coingecko:
Screen.Recording.2022-01-26.at.1.49.28.PM.mov