Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Network Identifications to Portfolio Asset Item #20902

Closed
Douglashdaniel opened this issue Feb 4, 2022 · 1 comment · Fixed by brave/brave-core#12173
Closed

Add Network Identifications to Portfolio Asset Item #20902

Douglashdaniel opened this issue Feb 4, 2022 · 1 comment · Fixed by brave/brave-core#12173
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

To prepare for Multi Chain support we need to add network identifications to the Portfolio Asset Item

  1. Add small Network icon next to the Asset icon
  2. Add the Network name next to the Asset symbol

image
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 4, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 4, 2022
@Douglashdaniel Douglashdaniel changed the title Add Network Icon to Portfolio Asset Item Add Network Identifications to Portfolio Asset Item Feb 4, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 8, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 8, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 28, 2022 •
edited
Loading

Verification completed using

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.1 (Build 21C52)
  • Add small Network icon next to the Asset icon
  • Add the Network name next to the Asset symbol
OP FTM AVAX BSC MATIC ETH
Screen Shot 2022-03-28 at 11 10 13 AM Screen Shot 2022-03-28 at 11 10 24 AM Screen Shot 2022-03-28 at 11 10 33 AM Screen Shot 2022-03-28 at 11 10 46 AM Screen Shot 2022-03-28 at 11 10 53 AM Screen Shot 2022-03-28 at 11 11 02 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Network Identifications in Portfolio brave/brave-core
2 participants
@Uni-verse @Douglashdaniel