Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Network Identifications in Portfolio #12173

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Added Network Identifications in Portfolio

  1. Now displays a Network icon on the Portfolio Asset Item along with a Description of the network for an asset.
  2. Now displays a Network icon for each network when selecting an Network unless there is now icon url specified for that network, will then default to the placeholder orb.

Resolves brave/brave-browser#20902

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2022-02-07.at.6.39.18.PM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 8, 2022 02:02
@Douglashdaniel Douglashdaniel self-assigned this Feb 8, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 8, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🚀

@Douglashdaniel Douglashdaniel force-pushed the network-identifications branch from 6a861c3 to 80ece88 Compare February 8, 2022 15:32
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 8, 2022
@Douglashdaniel Douglashdaniel merged commit 5ec1813 into master Feb 8, 2022
@Douglashdaniel Douglashdaniel deleted the network-identifications branch February 8, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Network Identifications to Portfolio Asset Item
3 participants