Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up Add Solana Account to UI #21054

Closed
Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12236 or brave/brave-core#12285
Closed

Wire up Add Solana Account to UI #21054

Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12236 or brave/brave-core#12285
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

  1. Wire up the AddAccount method in the UI to allow adding a Solana account.
  2. Use GetWalletInfo method to get Solana account information and display it in the UI.
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 11, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 11, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 12, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 16, 2022
@darkdh darkdh reopened this Feb 16, 2022
@darkdh darkdh mentioned this issue Feb 16, 2022
Merged
25 tasks
@srirambv
Copy link
Contributor

srirambv commented Mar 9, 2022

Brave 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12236
  • Verified create an account lists Solana as an option for creating a new account
  • Verified Solana option is listed for Create Account, Import, Import from hardware wallet
brave://flags/#brave-wallet-solana
Create Account
Import
Import from hardware wallet

@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
@yrliou yrliou mentioned this issue Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.37.x - Release
5 participants
@bbondy @kjozwiak @darkdh @srirambv @Douglashdaniel