Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Solana support for account creation, sending SOL and sending SPL tokens #22348

Closed
yrliou opened this issue Apr 15, 2022 · 1 comment · Fixed by brave/brave-core#13036
Closed

Enable Solana support for account creation, sending SOL and sending SPL tokens #22348

yrliou opened this issue Apr 15, 2022 · 1 comment · Fixed by brave/brave-core#13036
Assignees
@yrliou
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.39.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Apr 15, 2022 •
edited by Douglashdaniel
Loading

Enable the Solana feature flag by default on Desktop, current Solana feature includes the ability to create Solana accounts, get balances, transfer SOL, transfer SPL tokens, and manage visible user assets on Solana networks.

UI issues for this feature:
Add Solana accounts: #21054
Transfer SOL: #21891
Transfer SPL tokens: #22039
Display Solana transactions: #21892
Display Warning for Associated Token Account Creation: #22260

Test Plan:
Check Solana feature flag is enabled by default on Desktop browsers, and disabled by default on Andriod.
For actual feature testing, please refer to those UI issues listed above.
@yrliou yrliou self-assigned this Apr 15, 2022
@yrliou yrliou added this to Web3 Apr 15, 2022
@yrliou yrliou mentioned this issue Apr 15, 2022
Merged
25 tasks
@yrliou yrliou moved this to In Review in Web3 Apr 15, 2022
Repository owner moved this from In Review to Done in Web3 Apr 20, 2022
@yrliou yrliou added this to the 1.39.x - Nightly milestone Apr 20, 2022
@srirambv srirambv mentioned this issue Apr 26, 2022
Closed
@bbondy bbondy changed the title Enable Solana feature flag by default on Desktop Solana support May 20, 2022
@bbondy bbondy changed the title Solana support Enable Solana support for account creation, sending SOL and sending SPL tokens May 20, 2022
@srirambv
Copy link
Contributor

Brave 1.39.109 Chromium: 102.0.5005.50 (Official Build) (64-bit)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified Solana network is shown in network list
  • Verified Solana is listed under Add account
  • Verified Solana is listed under Import Account
  • Verified all UI related sub tasks work as expected

@LaurenWags LaurenWags mentioned this issue May 23, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111
6b60f4b 
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Enable Solana feature flag by default on Desktop brave/brave-core
2 participants
@yrliou @srirambv