-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce adblock filter memory usage by optimizing unused regex rules #21970
Reduce adblock filter memory usage by optimizing unused regex rules #21970
Comments
For QA: we should verify, that browser process memory consumption became 7mb less.
|
Verified
Below builds do not have fix
And
Verified test plan from #21970 (comment). Compared browser memory consumption on 1.39.86 to 1.38.109 and 1.37.105 and consumption is significantly less in Beta. 1.39.86 Chromium: 101.0.4951.41 1.38.109 Chromium: 101.0.4951.41 |
Verified with
Verified test plan from #21970 (comment). Compared 1.38.109 (current Release channel version) and 1.39.87 (current Beta channel version).
Verified test plan from #21970 (comment). Compared 1.38.109 (current Release channel version) and 1.39.84 (recent Beta channel version).
Verified test plan from #21970 (comment). Compared 1.38.109 (current Release channel version) and 1.39.87 (current Beta channel version).
|
Verified
|
Brave | 1.39.87 Chromium: 101.0.4951.41 (Official Build) beta (x86_64) |
---|---|
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904} |
OS | macOS Version 11.6.5 (Build 20G527) |
to compare against
Brave | 1.38.109 Chromium: 101.0.4951.41 (Official Build) (x86_64) |
---|---|
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904} |
OS | macOS Version 11.6.5 (Build 20G527) |
Confirmed, for my setup, that we dropped around 15MB in resident-set-size, on average.
Build |
Median |
---|---|
1.38.109 | 120 (120.4) |
1.39.87 | 105 (105.4) |
Breakdown:
1.38.109 (in MB) |
1.39.87 (in MB) |
---|---|
119 | 110 |
121 | 105 |
119 | 105 |
124 | 103 |
119 | 104 |
Verified PASSED
using
Brave | 1.39.84 Chromium: 101.0.4951.41 (Official Build) beta (arm64) |
---|---|
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904} |
OS | macOS Version 11.6.4 (Build 20G417) |
Confirmed, for my setup, that we dropped around 114MB in resident-set-size, on average.
Build |
Median |
---|---|
1.38.109 | 113 (113.2) |
1.39.84 | ** 99 (98.98)** |
Breakdown:
1.38.109 (in MB) |
1.39.84 (in MB) |
---|---|
116 | 101 |
113 | 101 |
112 | 95.1 |
112 | 96.8 |
113 | 101 |
Verification passed on
On 5 point average, 1.39.x uses 8MB less memory |
- Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348)) - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639)) - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831)) - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177)) - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278)) - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768)) - Added support for blob partitioning. ([#21746](brave/brave-browser#21746)) - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918)) - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686)) - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787)) - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557)) - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276)) - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104)) - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060)) - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068)) - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714)) - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428)) - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780)) - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970)) - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082)) - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550)) - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814)) - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958)) - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877)) - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044)) - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216)) - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305)) - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179)) - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
- Added Brave Firewall + VPN. ([#12197](brave/brave-browser#12197)) - Added support for blob partitioning. ([#21746](brave/brave-browser#21746)) - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276)) - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970)) - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082)) - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305)) - Fixed pending bell icon under Brave Wallet not being displayed when new unapproved requests are created. ([#21654](brave/brave-browser#21654)) - Fixed expand icon under Brave Shields using incorrect color when the Privacy Hub has been enabled. ([#22049](brave/brave-browser#22049)) - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
As discovered by @atuchin-m, there is an extra ~7MB that can be saved by optimizing the
regex
field ofNetworkFilter
inadblock-rust
. This was fixed inadblock-rust
as of v0.5.2.The text was updated successfully, but these errors were encountered: