Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome tab needs a favicon #584

Closed
srirambv opened this issue Jul 18, 2018 · 2 comments · Fixed by brave/brave-core#543
Closed

Welcome tab needs a favicon #584

srirambv opened this issue Jul 18, 2018 · 2 comments · Fixed by brave/brave-core#543

Comments

@srirambv
Copy link
Contributor

Actual result:

image

@srirambv srirambv added this to the Backlog milestone Jul 18, 2018
@rossmoody
Copy link
Contributor

rossmoody commented Jul 20, 2018

@cezaraugusto has been supplied the goods here. this should popup in a future update.

cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@bsclifton bsclifton changed the title Welcome tab needs a favcion Welcome tab needs a favicon Oct 2, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 2, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 4, 2018

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

image

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

screen shot 2018-10-08 at 3 49 54 pm

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment