Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to mute on macOS via tab audio icon after Chromium 100 #21829

Closed
LaurenWags opened this issue Mar 23, 2022 · 3 comments · Fixed by brave/brave-core#12719
Closed

unable to mute on macOS via tab audio icon after Chromium 100 #21829

LaurenWags opened this issue Mar 23, 2022 · 3 comments · Fixed by brave/brave-core#12719

Comments

@LaurenWags
Copy link
Member

Description

Found by @stephendonner

After Chromium 100 was merged to master, Nightly can no longer mute tabs by clicking on the audio icon on a tab.

This worked with Nightly 1.38.57 (Chromium 99) and does not work with Chromium 100 versions of Nightly (1.38.59,

Steps to Reproduce

  1. Download latest Nightly with Chromium 100
  2. Visit a site with audio (such as a youtube video)
  3. See audio icon on the tab once video starts to play
  4. Click on audio icon, nothing happens, video is not muted

Actual result:

Clicking on the audio icon of a tab does nothing

Expected result:

Clicking on the audio icon of a tab should mute the tab

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.38.65 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.3 (Build 21E230)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.36.x no
  • Can you reproduce this issue with the beta channel? 1.37.x no
  • Can you reproduce this issue with the nightly channel? 1.38.x yes, after chromium 100 merged

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/qa-team

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64

Brave | 1.38.65 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 10 Version 21H2 (Build 19044.1586)

@kjozwiak
Copy link
Member

Above requires 1.37.106 or higher for 1.37.x verification.

@stephendonner
Copy link

Verified PASSED using

Brave 1.37.106 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed I was able to mute and unmute audio of playing YouTube (and other) media, at will.

muted unmuted
Screen Shot 2022-03-27 at 10 56 36 AM Screen Shot 2022-03-27 at 10 56 41 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment