-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding favicons for custom chrome:// pages under Task Manager #1278
Comments
Favicon for welcome page is missing again in 0.59.12. Looks like regression issue. Logged #2747 |
I'd like to help on this one but it feels a little like a moving target. Might be helpful to break the favicons needed out into their own issues. |
I'll go ahead and take a shot at this issue! |
@rwhitman2017 check out our CONTRIBUTING.md for help getting started - let us know if there's anything we can help with |
pulling up task manager now - seems this has been fixed. There are some default icons showing there (like a globe): Gonna close this out as it's fixed. @rwhitman2017 feel free to find another issue and reach out 😄 |
Description
When viewing custom
chrome://
pages under the Task Manager, you'll notice that the favicons are blank. Shouldn't be hard to add favicons for these custom pages. Example of some pages affected:chrome://newtab
chrome://rewards
chrome://adblock
chrome://version
chrome://welcome
Steps to Reproduce
chrome://newtab
,chrome://rewards
,chrome://version
Actual result:
Expected result:
Custom
chrome://
pages should have favicons associated with them.Reproduces how often:
100% reproducible using the above STR.
Brave version (chrome://version info)
Reproducible on current release:
Yes, currently reproducible under the current release which is
0.55.6 Chromium: 70.0.3538.16
. Also reproducible with the latestmaster
:The text was updated successfully, but these errors were encountered: