Task manager shows Chromium instead of Brave

[srirambv]

Description

Task manager shows Chromium instead of Brave

Steps to Reproduce

1. Open task manager by pressing Shift+Esc
2. Main process shows Chromium icon instead of Brave
3. New tab icon shows generic icon

Actual result:

Expected result:

Reproduces how often:

100%

Brave version (about:brave info)

Packaged build most likely same on release build

cc: @simonhong @bbondy

[yrliou]

I think it's already been solved in current master, tried on Windows and Mac.
Feel free to reopen it if not, thanks!

[simonhong]

Recently chromium's IDR_PRODUCT_LOGO_16 is replaced with ours by #395.

I assume that task manager is affected by this change.

BrowserProcessTask::BrowserProcessTask()
    : Task(l10n_util::GetStringUTF16(IDS_TASK_MANAGER_WEB_BROWSER_CELL_TEXT),
           "Browser Process",
           FetchIcon(IDR_PRODUCT_LOGO_16, &s_icon_),
           base::GetCurrentProcessHandle()),
      used_sqlite_memory_(-1) {}

However, it should have more higher quality image than now :)

[bbondy]

@simonhong does another issue need to be created for what you mentioned in the last comment?

[simonhong]

Logo seems fine with this PR - https://github.com/brave/brave-core/pull/204/files

[srirambv]

Verification Passed on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

Verification Passed on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Mac OS X

[kjozwiak]

@yrliou noticed Tab: New Tab processes are still using generic icons on both Win & macOS. Example:

Is this expected? I don't see any mentions in this issue regarding the Tab: New Tab issue being fixed that @srirambv mentioned in #355 (comment). I searched out issues and couldn't find a bug. Reproduced on both master and the current released build.

CCing @srirambv as he might have more info regarding the above.

[bbondy]

@kjozwiak sounds like a new 1.x backog issue if you don't mind posting it.

[srirambv]

this happens to all chrome:// pages that has custom code

[bbondy]

we could supply a favicon easily, just need it tracked

[kjozwiak]

his happens to all chrome:// pages that has custom code

@srirambv yup, noticed the same thing as Tab: Adblock in my screen is also blank. I'll create a bug re: adding Brave icons for custom chrome:// pages.

we could supply a favicon easily, just need it tracked

Yup, I'll create the bug for tracking and add it into the 1.x backlog 👍

[kjozwiak]

@bbondy @srirambv created #1278.