Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set Show sidebar settings for release, beta, and nightly #21726

Closed
rebron opened this issue Mar 17, 2022 · 6 comments · Fixed by brave/brave-core#12644
Closed

set Show sidebar settings for release, beta, and nightly #21726

rebron opened this issue Mar 17, 2022 · 6 comments · Fixed by brave/brave-core#12644
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 17, 2022 •
edited
Loading

Description

For release channel, set Show sidebar as Never.
For beta and nightly channels, set Show sidebar as Always.

Expected result:

  1. New install or a create a new profile with a release build 1.37.x RC, beta and nightly build via hamburger menu.
  2. Notice no sidebar in release build but available to show or show on mouseover.
  3. Notice sidebar is default Show Always for beta and nightly channels.

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a. Starting with 1.37.x
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Mar 17, 2022
@simonhong simonhong self-assigned this Mar 17, 2022
@rebron rebron changed the title set Show sidebar new user settings for release, beta, and nightly set Show sidebar settings for release, beta, and nightly Mar 17, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 17, 2022
@simonhong
Updated sidebar show options based on channel
cb61117 
fix brave/brave-browser#21726

On Stable, sidebar is not visible by default.
Otherwise, it's shown.
@simonhong simonhong mentioned this issue Mar 17, 2022
Merged
25 tasks
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 17, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 17, 2022
@simonhong
Updated sidebar show options based on channel
5128ce2 
fix brave/brave-browser#21726

On Stable, sidebar is not visible by default.
Otherwise, it's shown.
@simonhong simonhong mentioned this issue Mar 17, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Above issue requires 1.37.98 or higher for verification on 1.37.x.

@LaurenWags
Copy link
Member

Added QA/Blocked as this requires an RC with 1.37.x to test.

@LaurenWags
Copy link
Member

Removing QA/Blocked as https://github.com/brave/brave-browser/releases/tag/v1.37.105 is available

This was referenced Mar 25, 2022
Closed
Closed
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 26, 2022 •
edited
Loading

Verification Passed

Brave (Nightly) 1.39.7 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)
Brave (Beta) 1.38.69 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)
Brave (Release) 1.37.105 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)
  • Launch Brave
  • Verified Sidebar is available in Normal Window, Private Window and Private Window with TOR in both Nightly and Beta and Sidebar is not available in Release
  • Verified Show Sidebar is set to Always as a default in Normal window when right clicked on Sidebar in both Nightly and Beta
  • Verified Show Sidebar Enabled entry set to 'Always in brave://settings/Appearance
  • Verified 'Show Sidebar Enabled' entry set to 'Never' in brave://settings/Appearance

Nightly

ex1 ex2 ex3
Nigtly-sidebar-always Nightly-TOR-Private-Hamburger-menu-sidebar Nightly-sidebar

Beta

ex1 ex2 ex3
Beta-normalwindow-sidebar Beta-sidebaralways Beta_Private_window_And_Private_window_Tor_Sidebar

Release

ex1 ex2
release-sidebar-never release-sidebar-never-private-Tor-window

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 26, 2022
@stephendonner
Copy link

stephendonner commented Mar 28, 2022 •
edited by GeetaSarvadnya
Loading

Verified PASSED using

Brave (release) 1.37.106 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)
Brave (beta) 1.38.69 Chromium: 100.0.4896.46 (Official Build) beta (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)
Brave (nightly) 1.39.5 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)
release - Show Sidebar -> Never Settings
Screen Shot 2022-03-27 at 6 33 25 PM Screen Shot 2022-03-27 at 6 33 40 PM
beta - Show Sidebar -> Always Settings
Screen Shot 2022-03-27 at 6 34 10 PM Screen Shot 2022-03-27 at 6 34 22 PM
nightly - Show Sidebar -> Always Settings
Screen Shot 2022-03-27 at 6 34 35 PM Screen Shot 2022-03-27 at 6 34 46 PM

Verification PASSED on

Brave 1.37.106 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 10 Version 21H2 (Build 19044.1586)
Brave 1.38.67 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 10 Version 21H2 (Build 19044.1586)
Brave 1.39.5 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 10 Version 21H2 (Build 19044.1586)
  • Verified both clean and upgraded profile and ensured that sidebar settings is set to Never by default in Normal/PT/Tor and Guest windows in Release channel

Release

  • Confirmed Show sidebar setting is set to Never in the Hamburger menu in the Release channel
  • Confirmed Show sidebar setting is set to Never in global settings in the Release channel
Hamburger menu Global settings
image image

Beta

  • Confirmed Show sidebar setting is set to Always in the Hamburger menu in the Beta channel
  • Confirmed Show sidebar setting is set to Always in global settings in the Beta channel
Hamburger menu Global settings
image image

Nightly

  • Confirmed Show sidebar setting is set to Always in the Hamburger menu in the Nightly channel
  • Confirmed Show sidebar setting is set to Always in global settings in the Nightly channel
Hamburger menu Global settings
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 28, 2022
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 28, 2022
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 labels Mar 28, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.37.107 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Ubuntu 18.04 LTS
image image

Verification passed on

Brave 1.38.70 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Ubuntu 18.04 LTS
image image

Verification passed on

Brave 1.39.10 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Ubuntu 18.04 LTS
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Updated sidebar show options based on channel brave/brave-core
8 participants
@stephendonner @kjozwiak @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya @MadhaviSeelam