Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sidebar show options based on channel #12644

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 17, 2022

fix brave/brave-browser#21726

On Stable, sidebar is not visible by default.
Otherwise, it's shown.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=*SidebarServiceTest*

  1. Launch non-stable channel release with clean profile
  2. Check sidebar show option is always.
  3. Launch stable channel release with clean profile
  4. Check sidebar show option is never

fix brave/brave-browser#21726

On Stable, sidebar is not visible by default.
Otherwise, it's shown.
@simonhong simonhong self-assigned this Mar 17, 2022
@simonhong simonhong requested a review from nullhook March 17, 2022 03:23
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 17, 2022
@simonhong simonhong merged commit 049eb8c into master Mar 17, 2022
@simonhong simonhong deleted the sidebar_show_default branch March 17, 2022 05:09
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.38.53 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Windows 10 Version 21H2 (Build 19044.1586)

Steps:

  1. installed 1.38.53
  2. launched Brave (beta)
  3. confirmed Sidebar is enabled with Show option Always pre-selected
  4. launched Brave (release)
  5. confirmed Sidebar isn't enabled/shown/available (checked brave://flags)
example example example
sidebar-beta sidebar-release sidebar-release-no-flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set Show sidebar settings for release, beta, and nightly
3 participants