Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to hide the Wallet icon in the Brave toolbar #19514

Closed
bbondy opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#12373
Closed

Make it easier to hide the Wallet icon in the Brave toolbar #19514

bbondy opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#12373
Assignees
@simonhong
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 16, 2021

Users can hide the Brave Wallet icon in brave://settings/wallet

But it's hard to discover that if you don't know.
It would be better to be able to right click on the icon and have a Hide option there in a menu.
@bbondy bbondy added OS/Desktop feature/web3/wallet Integrating Ethereum+ wallet support priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 16, 2021
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 18, 2021
@simonhong simonhong self-assigned this Feb 23, 2022
simonhong added a commit to brave/brave-core that referenced this issue Feb 23, 2022
@simonhong
Added context menu to brave wallet button on toolbar
5856a95 
fix brave/brave-browser#19514

This context menu includes hide wallet icon entry.
@simonhong simonhong mentioned this issue Feb 23, 2022
Merged
25 tasks
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 23, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.37.106 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed able to context-click and select Hide Brave Wallet icon on toolbar to remove the icon
Confirmed pref state is reflected in icon-visibility state, and vice-versa
Confirmed Show Brave Wallet icon on toolbar pref correctly sets and shows/hides the icon

example example example example
Screen Shot 2022-03-27 at 5 32 02 PM Screen Shot 2022-03-27 at 5 32 06 PM Screen Shot 2022-03-27 at 5 32 14 PM Screen Shot 2022-03-27 at 5 32 18 PM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
@aeimi
Copy link

aeimi commented Jul 24, 2022

Finally! Thank you stephendonner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Added context menu to brave wallet button on toolbar brave/brave-core
4 participants
@stephendonner @bbondy @simonhong @aeimi