Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary scroll bar on shields v2 for details view #21570

Closed
srirambv opened this issue Mar 9, 2022 · 1 comment · Fixed by brave/brave-core#12523
Closed

Remove unnecessary scroll bar on shields v2 for details view #21570

srirambv opened this issue Mar 9, 2022 · 1 comment · Fixed by brave/brave-core#12523
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 9, 2022

Description

Remove unnecessary scroll bar on shields v2 for details view

Steps to Reproduce

  1. Enable Shields v2 flag
  2. Visit any site and open shields
  3. Expand to advance view and click on blocked items, shows unnecessary scrollbars

Actual result:

image

Expected result:

Only show scrollbar when there is an overflow from visible box

Reproduces how often:

Easy

Brave version (brave://version info)

With flag enabled

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @nullhook @aguscruiz

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Mar 9, 2022
@nullhook nullhook self-assigned this Mar 10, 2022
@nullhook nullhook added this to the 1.38.x - Nightly milestone Mar 15, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 29, 2022

Brave 1.38.71 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)

Install 1.38.x
Launch Brave
Enable brave://flags/#brave-shields-v2
Click Relaunch

Testcase 1: No scrollbar displayed if there is no overflow of blocked items
  • Visited https://www.euronews.com/news/international
  • Open Shields and expand to Advance Controls
  • Click on the count (16) for Trackers and ads blocked
  • Verified there is no scrollbar displayed that listed blocked items in the box
ex1 ex2
shields v2 enabled No scrollbar
Testcase 2: Scrollbar displayed if there is overflow of blocked items
  • Visited another site, youtube.com
  • Play a video
  • Opened Shields and expand to Advance Controls
  • Clicked on the count (40) for Trackers and ads blocked
  • Clicked on (+) for one of the items to expand
  • Verified scrollbar displayed when there is an overflow from visible box
scrollbar-overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants