We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS, Tor, and Onion icons should be the same (all open new tabs)
1.37.46
ipns://ipfs.io
Use a Brave local IPFS node
https://ipfs.io
IPFS
The icon is different than our Tor and Onion icons, all of which open in a new tab.
Tor
Onion
IPFS, Tor, and Onion should all have the same icon; not sure which is correct.
100%
cc @rebron @spylogsster
The text was updated successfully, but these errors were encountered:
Looks like #21028 was resolved (albeit with .onion rather than Onion, which is fine) along with this.
.onion
Sorry, something went wrong.
@stephendonner yes, #21028 can be closed
Verification PASSED on
Brave | 1.37.52 Chromium: 98.0.4758.102 (Official Build) nightly (64-bit) -- | -- Revision | 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151} OS | Windows 10 Version 21H2 (Build 19044.1526)
IPFS:
TOR:
Onion:
Open in IPFS
1.37.x - Release
spylogsster
Successfully merging a pull request may close this issue.
Description
IPFS, Tor, and Onion icons should be the same (all open new tabs)
Steps to Reproduce
1.37.46
ipns://ipfs.io
Use a Brave local IPFS node
https://ipfs.io
IPFS
icon in the URL barActual result:
The icon is different than our
Tor
andOnion
icons, all of which open in a new tab.Expected result:
IPFS
,Tor
, andOnion
should all have the same icon; not sure which is correct.Reproduces how often:
100%
Brave version (brave://version info)
cc @rebron @spylogsster
The text was updated successfully, but these errors were encountered: