Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Private Ads text is not translated to other locales like Germany and France #21141

Closed
GeetaSarvadnya opened this issue Feb 16, 2022 · 2 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #21097
Brave Private Ads is not translated to other locales like Germany and France

Steps to Reproduce

  1. Set OS locale to Germany or France
  2. Enable Rewards
  3. Brave Private Ads is not translated to other locales like Germany and France

Actual result:

Brave Private Ads text is not translated to other locales like Germany and France
image

Expected result:

Brave Private Ads text should be translated to other locales like Germany and France

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.35.102 Chromium: 98.0.4758.102 (Offizieller Build) (64-Bit)
Überarbeitung 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
Betriebssystem Windows 10 Version 21H2 (Build 19044.1526)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @mkarolin @rebron

@rebron
Copy link
Collaborator

rebron commented Feb 22, 2022

@GeetaSarvadnya This should be fixed in the next pull. Can we recheck 1.36 once the translations are merged in.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Mar 17, 2022

@rebron The text Brave Private Ads is translated in other locales like Germany and France - Verified in 1.36.116 - Windows 10 x64

Germany France
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants