Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Dev Requires High Perf GPU on Mac #1151

Closed
kevinschaich opened this issue Sep 16, 2018 · 3 comments · Fixed by brave/brave-core#531
Closed

Brave Dev Requires High Perf GPU on Mac #1151

kevinschaich opened this issue Sep 16, 2018 · 3 comments · Fixed by brave/brave-core#531
Labels
OS/macOS perf QA Pass-macOS QA/Yes
Milestone
0.55.x - Release ...

Comments

@kevinschaich
Copy link

Description

Brave Dev requires the High-Performance GPU while Chrome / Safari do not. This can be a big drain on battery life.

Activity Monitor comparison:

image

Expected result:

Brave should use low-energy internal GPU for rendering by default for efficiency.

Reproduces how often:

Every Launch

Brave version (chrome://version info)

Brave Dev 0.55.4

Brave: 0.55.4 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision: ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS: Mac OS X

image
@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed OS/macOS perf labels Sep 17, 2018
@srirambv srirambv modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 17, 2018
@kevinschaich kevinschaich mentioned this issue Sep 20, 2018
Closed
@kevinschaich
Copy link
Author

Just another datapoint: disabling Hardware acceleration resolves this. We probably want internal GPU hardware acceleration though.

image

@rebron rebron modified the milestones: Releasable builds 0.55.x, 1.0 Sep 25, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog, Releasable builds 0.55.x Sep 29, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 1, 2018
@bbondy
Adjust GPU features to match Chrome
12266d2 
Chrome has oop rasterization and Viz disabled.

Fix brave/brave-browser#1219
Fix brave/brave-browser#1160
Fix brave/brave-browser#1151
@bbondy bbondy added the QA/Yes label Oct 1, 2018
@bbondy bbondy mentioned this issue Oct 1, 2018
Merged
11 tasks
@kjozwiak kjozwiak removed the needs-investigation A bug not 100% confirmed/fixed label Oct 15, 2018
@kjozwiak
Copy link
Member

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

screen shot 2018-10-15 at 5 05 51 pm

@vyrgozunqk
Copy link

Brave 0.68.139 Chromium: 77.0.3865.90, still suffers from the same issue. Maybe this reappeared at some point or a compilation flag was missed.

@btlechowski btlechowski mentioned this issue Feb 16, 2022
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 16, 2022
Closed
@stephendonner stephendonner mentioned this issue Feb 16, 2022
Closed
44 tasks
This was referenced Feb 16, 2022
Closed
Closed
@stephendonner stephendonner mentioned this issue Feb 16, 2022
Closed
@stephendonner stephendonner mentioned this issue Feb 17, 2022
Closed
@onchov onchov mentioned this issue Feb 17, 2022
Closed
This was referenced Feb 17, 2022
Closed
Closed
@kayzzen01 kayzzen01 mentioned this issue Feb 20, 2022
Open
@srirambv srirambv mentioned this issue Feb 21, 2022
Closed
@Adrian-Samoticha Adrian-Samoticha mentioned this issue Feb 21, 2022
Closed
@gabrielrozn gabrielrozn mentioned this issue Feb 22, 2022
Closed
@MadhaviSeelam MadhaviSeelam mentioned this issue Feb 23, 2022
Open
@wknapik wknapik mentioned this issue Feb 24, 2022
Open
@vishupal4185 vishupal4185 mentioned this issue Feb 26, 2022
Closed
@wknapik wknapik mentioned this issue Mar 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/macOS perf QA Pass-macOS QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adjust GPU features to match Chrome brave/brave-core
6 participants
@bbondy @kjozwiak @rebron @kevinschaich @srirambv @vyrgozunqk