Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes Disappear/Flicker on and Off #1160

Closed
andrewcking opened this issue Sep 17, 2018 · 15 comments · Fixed by brave/brave-core#531
Closed

Checkboxes Disappear/Flicker on and Off #1160

andrewcking opened this issue Sep 17, 2018 · 15 comments · Fixed by brave/brave-core#531

Comments

@andrewcking
Copy link

Description

So here is an odd issue, form checkboxes flicker in and out of visibility on Mac. I tested this on Windows and no such issue occurs.

Steps to Reproduce

  1. Visit a site with a checkbox on Mac. For example:
    https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_input_type_checkbox
    https://getbootstrap.com/docs/4.0/components/forms/#checkboxes-and-radios

  2. Click on the Checkbox

  3. Watch the box(es) go in and out of visibility

Actual result:

This is a video recorded on the w3 page listed above going over checkboxes.
https://streamable.com/dfry4

Expected result:

Checkboxes should not flicker in and out of visibility

Reproduces how often:

100% of the time

Brave version (chrome://version info)

Brave | 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision | ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}

Reproducible on current release:

This does not occur on the laptop version of brave

Website problems only:

This does not occur on chromium. It occurs in Brave with no extensions installed and with brave shield off.

@srirambv srirambv added bug needs-investigation A bug not 100% confirmed/fixed OS/macOS labels Sep 17, 2018
@srirambv srirambv added this to the 2.x Backlog milestone Sep 17, 2018
@kevinschaich
Copy link

kevinschaich commented Sep 18, 2018

Seeing this as well on the same version of Brave Dev on Mac as @andrewcking. Not just on one website, on multiple websites, and happens with Shields both on and off.

I recorded a quick GIF of the behavior:

checkbox

@kevinschaich
Copy link

This is actually happening not just for checkboxes but also radio buttons:

image

@rebron rebron modified the milestones: 2.x Backlog, Releasable builds 0.55.x Sep 18, 2018
@cndouglas
Copy link
Contributor

Which version of macOS is this? Reminds me of brave/browser-laptop#14348 (problem with macOS 10.14 Mojave).

@kevinschaich
Copy link

I’m able to reproduce on both my work laptop (High Sierra) and my personal laptop (Mojave public beta).

@andrewcking
Copy link
Author

andrewcking commented Sep 20, 2018

55.5 fixed this for me (Mac - High Sierra)
Edit - No still broken but seems to be intermittent

@kevinschaich
Copy link

kevinschaich commented Sep 20, 2018

Thanks for the suggestion @andrewcking. Glad that fixed it for you. Unfortunately for me it's still broken on 0.55.5:

screen shot 2018-09-19 at 11 07 21 pm

If anyone is having trouble reproducing, I see it pretty reliably on StickerMule's site (although this is not the only site where it manifests).

Also note that I tried clearing all browser data from Brave as well as a (relatively nuclear) manual option:

sudo find ~/Library -iname '*brave*' -delete

Let me know if there's stuff outside of ~/Library I should try as well.

@andrewcking
Copy link
Author

I played around with it again and I was able to get some radio buttons to disappear on me - so my earlier statement may have just been one of poor timing. Yep, still broken.

@kevinschaich
Copy link

kevinschaich commented Sep 20, 2018

OK, I think I may have narrowed the issue down to something possibly useful. Turing Hardware acceleration off fixes the problem for me:

image

Found this after some digging on Google / StackOverflow. @andrewcking – want to give this a try and see if it works for you as well?

Possibly related to #1151 I also recently filed.

@Brave-Matt
Copy link

@bsclifton
Copy link
Member

bsclifton commented Sep 28, 2018

A similar issue was reported on browser-laptop with brave/browser-laptop#14348

User @hansemannn shared an extension they made which works around the issue:

It's interesting to see the fix was to change the zoom level for the page. I reproduced the problem using brave-core on my mac and verified that increasing the zoom level does cause the checkbox / option boxes to render properly. Hopefully this provides a hint to where the problem is 😄

@notDavid
Copy link

and verified that increasing the zoom level does cause the checkbox / option boxes to render properly

fyi, what i always do when this problem occurs is quickly hit CMD + Tab twice (switch to another window and back), which also fixes it

@cndouglas
Copy link
Contributor

@bsclifton Do you have hardware acceleration on? #1160 (comment) says turning it off fixed the issue.

@jiripospisil
Copy link

I can reproduce as well. Disabling hardware acceleration fixes the issue.

https://streamable.com/zjlha
macOS High Sierra 10.13.6
Version 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)

@srirambv
Copy link
Contributor

+1 from @sundarms via #1355 for radio buttons not being rendered

bbondy added a commit to brave/brave-core that referenced this issue Oct 1, 2018
@bbondy bbondy added the QA/Yes label Oct 1, 2018
This was referenced Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.