Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP for non-US/CAN locales contains chrome webstore tile #5376

Closed
LaurenWags opened this issue Jul 24, 2019 · 3 comments · Fixed by brave/brave-core#3255
Closed

NTP for non-US/CAN locales contains chrome webstore tile #5376

LaurenWags opened this issue Jul 24, 2019 · 3 comments · Fixed by brave/brave-core#3255

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #3574

New Tab Page on non-US or Canada English locales still displays the chrome webstore top tile on fresh install. This was removed with #3710 but looks like it was only fixed for US/Can locales.

Steps to Reproduce

  1. Set your language/locale to be something other that English/US or English/Can. I tried English/UK, French/France, Hebrew, and Arabic.
  2. Clean profile, launch Brave.
  3. Open new tab page.

Actual result:

NTP shows chrome webstore link:
English/UK:
Screen Shot 2019-07-24 at 3 39 26 PM

French/France:
Screen Shot 2019-07-24 at 3 40 31 PM

Hebrew:
Screen Shot 2019-07-24 at 3 21 38 אח׳

Arabic:
Screen Shot ٢٠١٩-٠٧-٢٤ at ٣ ٢٢ ٣٢ م

Expected result:

NTP should not have chrome webstore link on clean install.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.66.101 Chromium: 75.0.3770.142 (Build officiel) (64 bits)
Révision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
Système d'exploitation Mac OS X
Brave 0.67.112 Chromium: 76.0.3809.62 (Build officiel) beta (64 bits)
Révision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
Système d'exploitation Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure but probably yes
  • Can you reproduce this issue with the nightly channel? unsure but probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Jul 24, 2019

cc: @cezaraugusto

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 9, 2019
@GeetaSarvadnya
Copy link

The issue is Reproducible in

Brave 0.67.123 Chromium: 76.0.3809.87 (Official Build) (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

@cezaraugusto cezaraugusto self-assigned this Aug 22, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 26, 2019
fix brave/brave-browser#5376

previous fix referenced the URL locale allowing the tile to still
show for locales other than en-US.
@kjozwiak kjozwiak added this to the 0.71.x - Nightly milestone Aug 27, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 17, 2019

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • The original issue is reproduced in 0.67.123, 0.67.125 and 0.68.138
    image
  • Verified the STR from the description, CWS tile is NOT displayed for France, English (UK), Arabic, Hebrew, English (South Africa)

France:
image

English -UK:
image

Hebrew:
image

Verification passed on

Brave 0.69.127 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description, CWS tile is NOT displayed for France, English (UK), Arabic, Hebrew, English (South Africa)
    image
    image

Verified passed with

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-09-24 at 15 54 36

Screen Shot 2019-09-24 at 15 55 29

Screen Shot 2019-09-24 at 3 58 15 אח׳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants