-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP for non-US/CAN locales contains chrome webstore tile #5376
Labels
bug
feature/new-tab
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
cc: @cezaraugusto |
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Aug 9, 2019
The issue is Reproducible in
|
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Aug 26, 2019
fix brave/brave-browser#5376 previous fix referenced the URL locale allowing the tile to still show for locales other than en-US.
6 tasks
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/new-tab
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
Found while testing #3574
New Tab Page on non-US or Canada English locales still displays the chrome webstore top tile on fresh install. This was removed with #3710 but looks like it was only fixed for US/Can locales.
Steps to Reproduce
Actual result:
NTP shows chrome webstore link:
English/UK:
French/France:
Hebrew:
Arabic:
Expected result:
NTP should not have chrome webstore link on clean install.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: