Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu item for triggering WebUI for the Ethereum wallet #4579

Closed
bbondy opened this issue May 23, 2019 · 4 comments · Fixed by brave/brave-core#2496
Closed

Add a menu item for triggering WebUI for the Ethereum wallet #4579

bbondy opened this issue May 23, 2019 · 4 comments · Fixed by brave/brave-core#2496

Comments

@bbondy
Copy link
Member

bbondy commented May 23, 2019

Test Plan

brave/brave-core#2496

This should only be on when the feature flag from #4578 is on.

@bbondy bbondy changed the title Add a menu item for triggering web-ui for the Ethereum wallet. Add a menu item for triggering web-ui for the Ethereum wallet May 23, 2019
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label May 23, 2019
@bbondy bbondy changed the title Add a menu item for triggering web-ui for the Ethereum wallet Add a menu item for triggering WebUI for the Ethereum wallet May 23, 2019
ryanml added a commit to brave/brave-core that referenced this issue May 24, 2019
@ryanml ryanml added this to the 0.67.x - Nightly milestone May 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue May 29, 2019
@LaurenWags
Copy link
Member

@bbondy @ryanml since 0.67.x packaged builds are official builds - is it enough to ensure that the menu item specified in test plan (brave/brave-core#2496) is not available and that visiting brave://wallet does not work?

@bbondy
Copy link
Member Author

bbondy commented Jul 25, 2019

I think we should just for now make sure that it doesn't show up in the builds. Then when we release the feature we should probably look at all the closed issues that were behind a flag.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 25, 2019

Verification PASSSED on macOS 10.14.5 x64 using the following build:

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  • ensured that Crypto Wallet isn't visible under brave://settings
  • ensured that Crypto Wallet isn't visible anywhere under the hamburger menu
  • ensured that Crypto Wallet isn't visible anywhere under the user profile menu
  • ensured that brave://wallet can't be reached/resolved
  • ensured that chrome://wallet can't be reached/resolved
  • ensured that chrome://wallet isn't listed under brave://about/

Verified passed with macOS 10.13.6 using:

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  • ensured that Crypto Wallet isn't visible under brave://settings
  • ensured that Crypto Wallet isn't visible anywhere under the hamburger menu
  • ensured that Crypto Wallet isn't visible anywhere under the user profile menu
  • ensured that brave://wallet can't be reached/resolved
  • ensured that chrome://wallet can't be reached/resolved
  • ensured that chrome://wallet isn't listed under brave://about/

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS
  • ensured that Crypto Wallet isn't visible under brave://settings
  • ensured that Crypto Wallet isn't visible anywhere under the hamburger menu
  • ensured that Crypto Wallet isn't visible anywhere under the user profile menu
  • ensured that brave://wallet can't be reached/resolved
  • ensured that chrome://wallet can't be reached/resolved
  • ensured that chrome://wallet isn't listed under brave://about/

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • ensured that Crypto Wallet isn't visible under brave://settings
  • ensured that Crypto Wallet isn't visible anywhere under the hamburger menu
  • ensured that Crypto Wallet isn't visible anywhere under the user profile menu
  • ensured that brave://wallet can't be reached/resolved
  • ensured that chrome://wallet can't be reached/resolved
  • ensured that chrome://wallet isn't listed under brave://about/

@kjozwiak
Copy link
Member

kjozwiak commented Sep 27, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that both brave://wallet & chrome://wallet loads the crypto page without issues
  • ensured that Crypto Wallets under the hamburger menu loads the crypto page without issues
  • ensured that Crypto Wallets under the brave://settings header loads the crypto page without issues
  • ensured that chrome://wallet isn't listed under brave://about (same behaviour has `chrome://rewards which also isn't listed)

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that both brave://wallet & chrome://wallet loads the crypto page without issues
  • ensured that Crypto Wallets under the hamburger menu loads the crypto page without issues
  • ensured that Crypto Wallets under the brave://settings header loads the crypto page without issues
  • ensured that chrome://wallet isn't listed under brave://about (same behaviour has `chrome://rewards which also isn't listed)

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • ensured that both brave://wallet & chrome://wallet loads the crypto page without issues
    image

  • ensured that Crypto Wallets under the hamburger menu loads the crypto page without issues
    image

  • ensured that Crypto Wallets under the brave://settings header loads the crypto page without issues

  • ensured that chrome://wallet isn't listed under brave://about (same behaviour has `chrome://rewards which also isn't listed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment