Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a feature flag for enabling Ethereum wallet #4578

Closed
bbondy opened this issue May 23, 2019 · 1 comment · Fixed by brave/brave-core#2496
Closed

Add a feature flag for enabling Ethereum wallet #4578

bbondy opened this issue May 23, 2019 · 1 comment · Fixed by brave/brave-core#2496
Assignees
@ryanml
Labels
feature/ethereum-remote-client QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
0.67.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented May 23, 2019 •
edited by LaurenWags
Loading

Test Plan

brave/brave-core#2496

Enable it only in dev builds

You would enable it when:

#if !defined(OFFICIAL_BUILD)
@bbondy bbondy mentioned this issue May 23, 2019
Closed
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label May 23, 2019
@bbondy bbondy mentioned this issue May 23, 2019
Closed
ryanml added a commit to brave/brave-core that referenced this issue May 24, 2019
@ryanml
Resolves brave/brave-browser#4578 - adds enabled flag for Brave Wallet
0225a61
@bbondy bbondy mentioned this issue May 24, 2019
Closed
@ryanml ryanml added this to the 0.67.x - Nightly milestone May 24, 2019
@ryanml ryanml mentioned this issue May 24, 2019
Merged
28 tasks
This was referenced Jul 19, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

Labelling as QA/No as this will be verified via #4579.

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/ethereum-remote-client QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Adding Brave Wallet buildflag, menu item brave/brave-core
5 participants
@bbondy @kjozwiak @ryanml @srirambv @LaurenWags