Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon music shows outdated Chrome message even with shields down #3308

Closed
srirambv opened this issue Feb 11, 2019 · 12 comments
Closed

Amazon music shows outdated Chrome message even with shields down #3308

srirambv opened this issue Feb 11, 2019 · 12 comments

Comments

@srirambv
Copy link
Contributor

Description

Amazon music shows outdated Chrome message even with shields down

Steps to Reproduce

  1. Visit https://music.amazon.co.uk/ in Brave (any channel)
  2. Disable/Enable shields, shows Chrome outdated error
  3. Open dev tools, console logs error even when shields is disabled

Actual result:

image
on Chrome
image

Expected result:

Same behaviour as Chrome

Reproduces how often:

Easy

Brave version (brave://version info)

Happens on all release/beta/dev channel builds

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Issue reported on community
https://community.brave.com/t/not-working-on-amazon-music-website-brave-v-0-59-34-chromium-72-0-3626-81/44666/1

@srirambv srirambv added bug webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes release-notes/include labels Feb 11, 2019
@mrzealot
Copy link

As per Slack, this is related to the Widevine component that the site detects as missing. Probably not much we can do, apart from making our native warning more obvious, as discussed in #1940.

@bbondy bbondy added closed/wontfix and removed QA/Yes bug release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Mar 5, 2019
@bbondy bbondy added this to the Dupe / Invalid / Not actionable milestone Mar 5, 2019
@bbondy
Copy link
Member

bbondy commented Mar 5, 2019

We already landed the new UX for making Widevine more obvious, so I'm closing this.

@bbondy bbondy closed this as completed Mar 5, 2019
@jonathansampson
Copy link
Contributor

Looks like this is still an issue, and unlikely related to Widevine.

image

Doesn't appear to work with shields down.

@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone Jul 24, 2019
@kjozwiak kjozwiak added bug plugin/Widevine webcompat/not-shields-related Sites are breaking because of something other than Shields. and removed closed/wontfix labels Jul 24, 2019
@kjozwiak
Copy link
Member

Reproduced the issue on macOS 10.14.5 x64 using the following build:

Brave 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Mac OS X

When you initially visit https://music.amazon.com, you receive the Widevine modal as expected:

Screen Shot 2019-07-24 at 12 16 23 PM

However, once you start attempting to play some music, you'll receive the following as @srirambv & @jonathansampson pointed out above:

Screen Shot 2019-07-24 at 12 16 48 PM

@kjozwiak
Copy link
Member

Looks like this has been fixed on dev & nightly:

  • 0.70.3 Chromium: 76.0.3809.62 (Official Build) nightly - Couldn't reproduce (Working)
  • 0.69.91 Chromium: 76.0.3809.62 (Official Build) dev - Couldn't reproduce (Working)
  • 0.67.115 Chromium: 76.0.3809.62 (Official Build) beta - Issue reproduced (doesn't work)

@btlechowski @GeetaSarvadnya mind checking to see if you're getting the same results on Windows & Linux?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 25, 2019

@kjozwiak Issue is Reproducible on Windows 10 x64 - 0.67.117

After playing any music, I am seeing the below popup message.

image

@kjozwiak
Copy link
Member

@GeetaSarvadnya does it work on 0.70.x and 0.69.x for you as well?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 25, 2019

@kjozwiak Yup. It's working for me on dev and nightly on versions below:

Dev channel 0.68.106 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Dev channel 0.69.92 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Nightly channel 0.70.3 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)

@kjozwiak
Copy link
Member

kjozwiak commented Aug 21, 2019

As per the above, seems like this has been fixed and is working as expected. Assuming this has been fixed via #4793. Also verified it's working with 0.68.131 Chromium: 76.0.3809.100.

@srirambv mind taking a look as well as you originally reported the issue? Thanks!

@kjozwiak
Copy link
Member

kjozwiak commented Aug 21, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Verification passed on

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified test plan from the description.

Verification passed on

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from the description.

@rsc3
Copy link

rsc3 commented May 24, 2023

I'm getting a similar issue on Fedora38 in 2023. Accepted the wildvine install popup.

@rsc3
Copy link

rsc3 commented May 24, 2023

Ah now I see that wildvine didn't actually install. Same issue with Firefox :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants