using CHROMN as attribution when quick searching using Bing (not default SE) for upgraded profiles - follow up to 20659

[LaurenWags]

Description

Found while testing #20659

Using quick search for Bing (:b followed by search term) in omnibox when Bing is not the default SE, still uses PC=U316&FORM=CHROMN in the URL bar for upgraded profiles.

Clean profiles (with 1.36.x) behave as expected.

See discussion under https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1644511815398559?thread_ts=1643942748.480089&cid=CHGKGMHDJ

Steps to Reproduce

Scenario 1:

1. Install 1.35.101.
2. Launch to create a profile, search using default SE (Brave search).
3. Close.
4. Rename profile to Beta.
5. Launch with latest 1.36.x.
6. Do a new search from omnibox (ex. :b hats).
7. Resulting URL contains PC=U316&FORM=CHROMN.

Scenario 2:

1. Install 1.35.101.
2. Do not change default SE (Brave search).
3. Search using Bing via omnibox (ex. :b shoes).
4. Resulting URL contains PC=U316&FORM=CHROMN.
5. Close.
6. Rename profile to Beta.
7. Launch with latest 1.36.x Beta version.
8. Do a new search from omnibox (ex. :b hats).
9. Resulting URL contains PC=U316&FORM=CHROMN.

Actual result:

Quick search for Bing (:b) from omnibox on upgrade profiles where Bing is not the default SE still has PC=U316&FORM=CHROMN in the search URL. Does not reproduce when Bing is the default SE or on a clean profile w/ Bing quick search with 1.36.x.

Expected result:

Bing search URL should not contain PC=U316&FORM=CHROMN

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (x86_64)
Revision	e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS	macOS Version 12.2.1 (Build 21D62)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @simonhong

[LaurenWags]

Does not reproduce in the following cases:

Clean profile case:

1. Install 1.36.x.
2. Launch.
3. Do a new quick search from omnibox (ex. :b hats) to use Bing.
4. Resulting URL does not contain PC=U316&FORM=CHROMN.

Upgrade case where Bing is default SE:

1. Install 1.35.101.
2. Change default SE to Bing.
3. Search using Bing via omnibox (ex. shoes).
4. Resulting URL contains PC=U316&FORM=CHROMN.
5. Close.
6. Rename profile to Beta.
7. Launch with 1.36.x.
8. Do a new search from omnibox (ex. laptop).
9. Resulting URL does not contain PC=U316&FORM=CHROMN.

[bsclifton]

OK found root cause! will work on a fix here 😄

[kjozwiak]

Will require 1.36.99 or higher.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.36.99 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
-- | --
Revision | 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS | Windows 10 Version 21H2 (Build 19044.1526)

• Verified the STR from the description.
• Reproduced the issue in 1.36.90
• Confirmed resulting URL doesn't show chrome attribution PC=U316&FORM=CHROMN
  

---

Verified PASSED using

Brave	1.36.99 Chromium: 98.0.4758.102 (Official Build) beta (x86_64)
Revision	273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS	macOS Version 11.6.3 (Build 20G415)

Followed @LaurenWags steps to reproduce and verified the fix.

Confirmed in both scenarios that the attribution PC=U316&FORM=CHROMN is no longer present.

Scenario One	Scenario Two

---

Verification passed on

Brave	1.36.104 Chromium: 98.0.4758.109 (Official Build) beta (64-bit)
Revision	03268453da2c7409eb1ee934d97abfc6f3b45420-refs/branch-heads/4758@{#1179}
OS	Ubuntu 18.04 LTS

Verified the STR from the description.

Scenario 1
after upgrade

Scenario 2
in 1.35.x:

after upgrade