Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search version after attribution removed from Bing (uplift to 1.36.x) #12294

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Update search version after attribution removed from Bing (uplift to 1.36.x) #12294

merged 1 commit into from
Feb 17, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 16, 2022 •
edited by kjozwiak
Loading

Uplift of #12290
Fixes brave/brave-browser#21085

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team February 16, 2022 11:49
@brave-builds brave-builds self-assigned this Feb 16, 2022
@brave-builds brave-builds added this to the 1.36.x - Beta milestone Feb 16, 2022
@kjozwiak
Copy link
Member

macOS failed due to BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe failing as per https://ci.brave.com/job/pr-brave-browser-pr12290_bsc-update-search-version_1.36.x-macos/1/testReport/(root)/BraveShieldsAPIBrowserTest/macos_x64___test_browser___AllowScriptsOnceIframe/. However, this is a known intermittent issue as per brave/brave-browser#20785 and doesn't block uplift.

kjozwiak
kjozwiak approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12290 (comment).

@kjozwiak kjozwiak merged commit 3687382 into 1.36.x Feb 17, 2022
@kjozwiak kjozwiak deleted the pr12290_bsc-update-search-version_1.36.x branch February 17, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases