Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave's Windows updater (Omaha) #21564

Closed
mherrmann opened this issue Mar 9, 2022 · 4 comments · Fixed by brave/brave-core#12557
Closed

Update Brave's Windows updater (Omaha) #21564

mherrmann opened this issue Mar 9, 2022 · 4 comments · Fixed by brave/brave-core#12557

Comments

@mherrmann
Copy link

mherrmann commented Mar 9, 2022

Description

In brave/omaha#45, some statistics collection is disabled in Brave's auto-updater on Windows. For this change to reach users, we need to release a new version of the auto-updater.

In my opinion, the following PRs in brave/omaha should be merged on the way to achieving the above:

  1. Disable Brave stats pings to /installerEvent omaha#45 this is the meat of the implementation (little there is).
  2. Bump version to 1.361.113 omaha#46 this increments the version number of the updater so users can receive it via auto-updates.
  3. Don't require KEY_PFX_PATH & AUTHENTICODE_PASSWORD omaha#43 this is a non-functional build process change, which we might as well merge into our mainline at this point.
  4. Use parallel builds to speed up compilation omaha#47 speeds up the build process by using parallel compilation.

Once the above are merged, we need to update the omaha dependency in Brave's DEPS file. Then, we need to build the new updater (happens as part of Brave's normal build) and upload its binaries to the update server. @mihaiplesa did this in November last year and will know whether it is done automatically as parts of Brave's release builds, or whether it needs to be done manually.

@mherrmann
Copy link
Author

@mihaiplesa I'm re-opening this because we had to rollback yesterday.

The reason for the rollback is that we saw an increasing number of CI builds fail with the following error:

"C:\go/bin/go.exe" run C:\ws\src\brave\vendor\omaha\omaha/../common/certificate_tag/certificate_tag.go -set-superfluous-cert-tag=Gact2.0Omaha -padded-length=8206 -out scons-out\opt-win\obj\standalone\UNOFFICIAL_BraveBrowserStandaloneUntaggedNightlySetup_99_1_38_52.exe scons-out\opt-win\obj\standalone\authenticode_UNOFFICIAL_BraveBrowserStandaloneUntaggedNightlySetup_99_1_38_52.exe
go: cannot find GOROOT directory: C:\go
scons: *** [scons-out\opt-win\obj\standalone\UNOFFICIAL_BraveBrowserStandaloneUntaggedNightlySetup_99_1_38_52.exe] Error 2
scons: building terminated because of errors.
Error in hammer.bat:96.

@mherrmann
Copy link
Author

Closing this issue in favor of #22060.

@LaurenWags
Copy link
Member

@mherrmann is it ok to mark this one as QA/No as we will test this with #22060 ?

@mherrmann
Copy link
Author

@LaurenWags yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants