Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Brave stats pings to /installerEvent #45

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

mherrmann
Copy link
Collaborator

Resolves #41.

Note: For this implementation to be deployed to users, a few additional steps in Brave are needed. I will open an issue in brave-browser for this.

@mihaiplesa mihaiplesa requested review from porteron and simonhong March 9, 2022 16:35
Copy link
Member

@porteron porteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mherrmann mherrmann merged commit 0e60fa4 into rebase-v1.3.36.111 Mar 10, 2022
@mihaiplesa mihaiplesa deleted the disable-brave-stats-pings branch March 10, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable requests to /installerEvents for stats updater
4 participants