Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Brave stats pings to /installerEvent #45

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Disable Brave stats pings to /installerEvent #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 0 additions & 91 deletions omaha/common/brave_stats_updater.cc
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions omaha/common/brave_stats_updater.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion omaha/common/build.scons
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def BuildCommonLib(env):
inputs = [
'app_registry_utils.cc',
'brave_referral_code_utils.cc',
'brave_stats_updater.cc',
'command_line.cc',
'command_line_builder.cc',
'config_manager.cc',
Expand Down
4 changes: 0 additions & 4 deletions omaha/goopdate/download_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
#include "omaha/base/synchronized.h"
#include "omaha/base/user_rights.h"
#include "omaha/base/utils.h"
#include "omaha/common/brave_stats_updater.h"
#include "omaha/common/config_manager.h"
#include "omaha/common/const_goopdate.h"
#include "omaha/common/google_signaturevalidator.h"
Expand Down Expand Up @@ -279,9 +278,6 @@ HRESULT DownloadManager::DownloadApp(App* app) {
}

if (SUCCEEDED(hr)) {
omaha::BraveSendStatsPing(_T("download-complete"), app->app_guid_string(),
app->referral_id(),
app_version->app()->next_version()->version());
app->DownloadComplete();
app->MarkReadyToInstall();
} else {
Expand Down
4 changes: 0 additions & 4 deletions omaha/goopdate/install_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "omaha/base/scope_guard.h"
#include "omaha/base/synchronized.h"
#include "omaha/base/utils.h"
#include "omaha/common/brave_stats_updater.h"
#include "omaha/common/config_manager.h"
#include "omaha/common/const_cmd_line.h"
#include "omaha/common/install_manifest.h"
Expand Down Expand Up @@ -120,9 +119,6 @@ void InstallManager::InstallApp(App* app, const CString& dir) {

HANDLE primary_token(app->app_bundle()->primary_token());

omaha::BraveSendStatsPing(_T("installer-run"), app->app_guid_string(),
app->referral_id(), next_version->version());

HRESULT hr = InstallApp(is_machine_,
primary_token,
current_version_string,
Expand Down
6 changes: 0 additions & 6 deletions omaha/mi_exe_stub/mi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
#include "omaha/base/system_info.h"
#include "omaha/base/utils.h"
#include "omaha/common/brave_referral_code_utils.h"
#include "omaha/common/brave_stats_updater.h"
#include "omaha/common/const_cmd_line.h"
#include "omaha/mi_exe_stub/process.h"
#include "omaha/mi_exe_stub/mi.grh"
Expand Down Expand Up @@ -765,11 +764,6 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE, LPSTR lpCmdLine, int) {
omaha::StorePathToRegForPromoCode(lpCmdLine);

const CString referral_code = omaha::GetReferralCodeFromModuleFileName();
if (CString(lpCmdLine).IsEmpty()) {
const CString app_guid = omaha::ReadAppGuidFromTag(hInstance);
hr = omaha::BraveSendStatsPing(_T("startup"), app_guid, referral_code,
_T(""));
}

omaha::MetaInstaller mi(hInstance, lpCmdLine, referral_code);
int result = mi.ExtractAndRun();
Expand Down