Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy requests for CRLSets through crlsets[n].brave.com #2160

Closed
jumde opened this issue Nov 16, 2018 · 4 comments · Fixed by brave/brave-core#920, brave/brave-core#997 or brave/brave-core#1581

Comments

@jumde
Copy link
Contributor

jumde commented Nov 16, 2018

Test Plan

  1. Open Brave Browser with a fresh profile
  2. Navigate to brave://components (wait for a few mins) and verify that CRLSets is updated. It should have a non-zero version number.
  3. Verify that no requests are sent to:
www.google.com/dl/release2/chrome_component/*crl-set*
*.gvt1.com/edgedl/release2/chrome_component/*crl-set*
*://dl.google.com/release2/chrome_component/*crl-set*
@jumde jumde self-assigned this Nov 16, 2018
@diracdeltas diracdeltas added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 26, 2018
@bbondy bbondy added this to the 0.58.x - Dev milestone Nov 28, 2018
@jumde
Copy link
Contributor Author

jumde commented Nov 29, 2018

Reverted: brave/brave-core#986 (master and 0.58.x)

@jumde jumde reopened this Nov 29, 2018
@jumde jumde modified the milestones: 0.58.x - Beta, 1.x Backlog Nov 29, 2018
@diracdeltas
Copy link
Member

also need to proxy the update.googleapis.com request from #2280

@jumde jumde modified the milestones: 1.x Backlog, 0.60.x - Nightly Dec 11, 2018
@bbondy bbondy modified the milestones: 0.60.x - Dev, 1.x Backlog Dec 15, 2018
@bbondy bbondy reopened this Dec 15, 2018
@bbondy
Copy link
Member

bbondy commented Dec 15, 2018

Had to be reverted, follow logic here:
brave/brave-core#997 (comment)

@LaurenWags
Copy link
Member

LaurenWags commented May 8, 2019

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image
image

Verification passed on

Brave 0.64.74 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux
  • Verified on clean profile, components had non-zero values
  • Verified no connections were made to Google servers
  • Verified Brave components showed both state Component not update and Up-to-date
    image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment