Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting crlsets #986

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Reverting crlsets #986

merged 2 commits into from
Nov 29, 2018

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Nov 29, 2018 •
edited
Loading

fix brave/brave-browser#2280

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jumde
Revert "Merge pull request #652 from brave/crlsets"
decf66b 
This reverts commit 92e9424, reversing
changes made to 1698b31.
@jumde
Revert "Merge pull request #920 from brave/crlset_proxies"
c88e7ad 
This reverts commit f8f2b2e, reversing
changes made to e4bc857.
diracdeltas
diracdeltas approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this built on MacOS and doesn't connect to update.googleapis.com

@diracdeltas
Copy link
Member

also confirmed network audit command passes

@jumde jumde merged commit 2b7c239 into master Nov 29, 2018
jumde added a commit that referenced this pull request Nov 29, 2018
@jumde
Merge pull request #986 from brave/reverting_crlsets
34c3735 
Reverting crlsets
@jumde
Copy link
Contributor Author

jumde commented Nov 29, 2018

master - 2b7c239
0.58.x - 34c3735

This was referenced Nov 29, 2018
Closed
Closed
Merged
Merged
bbondy pushed a commit that referenced this pull request Dec 4, 2018
@jumde @bbondy
Merge pull request #986 from brave/reverting_crlsets
ef052ce 
Reverting crlsets
@bbondy
Copy link
Member

bbondy commented Dec 4, 2018

Looks like 0.59.x cherry-pick was missed, so doing that here:
ef052ce

@NejcZdovc NejcZdovc deleted the reverting_crlsets branch December 4, 2018 13:30
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

brave makes request to update.googleapis.com on startup
3 participants
@jumde @diracdeltas @bbondy