Clicking on Shields, VPN, or Wallet icons should toggle panel shown/hidden; it remains shown

[stephendonner]

Description

Filing as proxy for @Miyayes who found this 🤜 🤛

Clicking on Shields icon should toggle panel shown/hidden; it remains shown

Steps to Reproduce

1. install 1.39.22
2. launch Brave
3. load brave.com
4. click (and let go) on the Brave Shields icon in the URL bar
5. confirm the panel opens
6. click the Brave Shields icon again to dismiss

Actual result:

After the click event is done, the Shields panel still remains.

Expected result:

Clicks should toggle the shown/hidden state of the panel, as it does in 1.37.x and earlier. The 2nd click after opening the panel should dismiss it.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.39.22 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision	6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS	macOS Version 11.6.5 (Build 20G527)

cc @nullhook @Tonev @Miyayes @rebron

[kjozwiak]

The above will require 1.38.105 or higher for 1.38.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.38.107 Chromium: 101.0.4951.41 (Official Build) (64-bit)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | Windows 10 Version 21H2 (Build 19044.1645)

• Encountered Descriptive text for Wallet and VPN icons on toolbar need to be consistent #22436
• Confirmed that clicking on the shield on any site opens up the shield panel, click on the shield icon again dismiss the shield panel on the website

Also Confirmed steps below for shield and wallet:

clicking the icon invokes a doorhanger panel, which remains until further, specific click(s)
clicking inside the panel does NOT dismiss (expected)
clicking again on the icon dismisses the doorhanger panel
clicking anywhere outside of the doorhanger panel dismisses it
panel is dismissed upon pressing esc