Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift 1.38.x - #12903 from brave/toolbar-button-panels-close #13074

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Uplift 1.38.x - #12903 from brave/toolbar-button-panels-close #13074

merged 1 commit into from
Apr 22, 2022

Conversation

petemill
Copy link
Member

Uplift brave/brave-browser#22026 via #12903.
Ensure panels opened via toolbar buttons get closed when clicked again (shields, vpn, wallet).

@petemill petemill added this to the 1.38.x - Beta milestone Apr 19, 2022
@petemill petemill requested a review from a team April 19, 2022 18:56
@petemill petemill self-assigned this Apr 19, 2022
@kjozwiak
Copy link
Member

Looks like Windows, macOS, Linux & Android failed due to CookieStoreTest/0.DeleteSessionCookie, CookieStoreTest/0.OverwritePersistentCookie, CookieStoreTest/0.TestCookieDeletion & CookieStoreTest/0.TestDeleteAll failing. However, this is a known issue and has been fixed via brave/brave-browser#22387. It was also uplifted into 1.38.x & 1.37.x. These don't block uplifting.

@kjozwiak
Copy link
Member

Restarting noplatforms as there seemed to timeout as per the following:

 Cannot contact i-0dad873004743d512-linux-swarm-201f34b1: java.lang.InterruptedException
15:20:43 
 Cancelling nested steps due to timeout

@petemill
Merge pull request #12903 from brave/toolbar-button-panels-close
746cc37 
Ensure panels opened via toolbar buttons get closed when clicked again (shields, vpn, wallet)
@petemill petemill force-pushed the 1.38.x-toolbar-button-panels-close branch from 6a63965 to 746cc37 Compare April 22, 2022 02:25
kjozwiak
kjozwiak approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12903 (comment).

@kjozwiak kjozwiak merged commit a89962e into 1.38.x Apr 22, 2022
@kjozwiak kjozwiak deleted the 1.38.x-toolbar-button-panels-close branch April 22, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@petemill @kjozwiak