Tab mute icon (to mute/unmute audio) is not clickable for tabs in the background

[Trikzbowii]

Description

Tab mute now requires you to click on to the tab to mute it.

Steps to Reproduce

1. Play audio on a tab
2. Leave audio playing on tab and change to a new tab
3. Click on mute to mute the audio on tab

Actual result:

Brave now requires you switch to the tab to mute it. So essentially a double click to mute a tab.

Expected result:

Click on audio icon to mute audio on said tab without switching to it

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.37.109 Chromium: 100.0.4896.60 (Official Build) (64-bit)

Version/Channel Information:

Current and Nightly

Other Additional Information:

N/A

Miscellaneous Information:

[rebron]

cc: @nullhook @emerick

[tdritsas]

Do we have any news about the issue?

[GuillaumeBonnet]

Installing an old version on windows 10:

As a temporary solution I installed an old version of Brave to get the feature back.

It's not a good idea regarding security and I don't know how to cleanly install an old version on windows 10 but it worked for me:

• got the feature back
• bookmarks are still there
• history still there
• need to login back on every sites
• brave icon in the windows task bar is now blank

Steps:

• go to an older stable release page like: https://github.com/brave/brave-browser/releases/tag/v1.36.122
• download brave-v1.36.122-win32-x64.zip
• go to C:\Program Files
• rename the C:\Program Files\BraveSoftware into C:\Program Files\BraveSoftwareNew (or store a backup of this folder)
• copy the content of the zip into a fresh C:\Program Files\BraveSoftware folder
• start brave.exe
• go in brave's settings, click on about and check that the version number matches.

[nullhook]

yes, I can confirm this is an issue. i believe it was introduced in cr100 update and also happens in Chrome. as a workaround you can right click > mute site on the tab to avoid context switch for now.

will discuss with @rebron on the fix

[tdritsas]

Hi do we have any news about this issue?

It was so much useful feature.

Please Brave turn it back we do not want to move to other browsers for that issue.

[tdritsas]

Hi is the issue fixed?

If yes, how can we check? is there any update.

Thanks

[simonhong]

@tdritsas PR is ready but not merged yet. Needs code review.
When it's merged you can test it in advance with nightly version.

[MadhaviSeelam]

Verified PASSED using

Brave	1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Windows 11 Version 21H2 (Build 22000.613)

Verified no longer have to switch to inactive tab to mute and unmute.

[kjozwiak]

Removing the QA Pass labels as this was uplifted into 1.38.x via brave/brave-core#13169 and will be pushed out via the 1.38.x maintenance release as per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates.

[tdritsas]

Hi to the todays update release 1.38.111 official built the mute tab option as i check is still not fixed.

[simonhong]

@tdritsas Hi, next release will include this fix.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
-- | --
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Windows 10 Version 21H2 (Build 19044.1706)

Reproduced the issue in 1.37.109 and upgraded the profile to 1.38.118 and confirmed the issue is fixed and working fine, user is no longer required to switch to the inactive audio tab to mute/unmute the audio

[Shadowized]

still not working correctly with v1.38.118 when you have a large number of tabs open, depending on the size of the browser window.

[simonhong]

@Shadowized it's expected behavior. When tab's width is small, mute button is disabled to make tab itself clickable.

[LaurenWags]

Verified with

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (x86_64)
-- | --
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | macOS Version 12.3.1 (Build 21E258)

Reproduced the issue as described using 1.38.115 Chromium: 101.0.4951.64.

Using 1.38.118 Chromium: 101.0.4951.67, confirmed able to click on the mute icon for inactive tab playing audio and the tab mutes as expected. Switching to the tab playing audio to mute it was not required except in case noted by @simonhong with small tab size.

Encountered and logged #22862, but it is not specific to versions with this fix - it occurs in current release version of 1.38.115.

[btlechowski]

Verification passed on

Brave	1.38.119 Chromium: 101.0.4951.67 (Official Build) (64-bit)
Revision	8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS	Ubuntu 18.04 LTS

Verified able to mute when tab is not the active tab