Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site banner should have 'on YouTube' text when appropriate #2238

Closed
LaurenWags opened this issue Nov 26, 2018 · 1 comment · Fixed by brave/brave-core#976
Closed

site banner should have 'on YouTube' text when appropriate #2238

LaurenWags opened this issue Nov 26, 2018 · 1 comment · Fixed by brave/brave-core#976

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 26, 2018

Description

When you go to tip a YouTube channel, the site banner now says the channel name and displays channel favicon. However, site banner does not indicate that the site is 'on YouTube' as it does on the Brave panel (when you click on BAT logo) or on the Brave Rewards page (in AutoContribute table).

Steps to Reproduce

  1. If not already enabled, enable Brave Rewards.
  2. Navigate to https://www.youtube.com/channel/UCFNTTISby1c_H-rm5Ww5rZg
  3. View a video.
  4. Click on BAT logo. Note that you see 'on YouTube' text on the panel.
  5. Click on Send a Tip

Actual result:

Site banner displays, but does not have 'on YouTube' text:
screen shot 2018-11-26 at 4 12 57 pm

Expected result:

Site banner should note 'on YouTube' to be consistent with Brave panel and Brave Rewards page.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

The 'on YouTube' text also displays on the brave://rewards page:
screen shot 2018-11-26 at 4 12 46 pm

screen shot 2018-11-26 at 4 12 37 pm

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 21, 2018

Verified passed with

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta(64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Mac OS X

screen shot 2018-12-21 at 3 06 09 pm

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10

image

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment