Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Look & feel" text should be removed from Shields global settings page #22382

Closed
Tracked by #22546
MadhaviSeelam opened this issue Apr 18, 2022 · 3 comments
Closed
Tracked by #22546

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 18, 2022

Description

Look & feel text should be removed from brave://settings/shields

Steps to Reproduce

  1. Install 1.38.90
  2. Launch brave
  3. Navigate to brave://settings/shields

Actual result:

Look & feel text is still displayed/retained from Shields V1

Look feel text

Expected result:

Look & feel text should be removed.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Closed with brave/brave-core#13209

@rebron rebron closed this as completed Jun 1, 2022
@rebron rebron added this to the 1.41.x - Nightly milestone Jun 1, 2022
@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Jun 8, 2022

Verification PASSED using

Brave | 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)
  • Install 1.41.47
  • Launch brave
  • Open brave://settings/shields
  • Verified Look & feel text is removed

image

Existing bug noticed while testing this: #23245

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Steps:

  1. installed 1.41.47
  2. launched Brave
  3. opened brave://settings/shields
  4. looked at the Shields section

Confirmed Look & feel heading text is removed

1.41.47 1.39.120
Screen Shot 2022-06-08 at 4 40 22 PM Screen Shot 2022-06-08 at 4 43 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants