-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Look & feel" text should be removed from Shields global settings page #22382
Closed
Tracked by
#22546
Labels
bug
OS/Desktop
OS/Windows
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
release-notes/exclude
Milestone
Comments
Closed
25 tasks
rebron
added
priority/P4
Planned work. We expect to get to it "soon".
release-notes/exclude
labels
Apr 19, 2022
rebron
added
priority/P3
The next thing for us to work on. It'll ride the trains.
and removed
priority/P4
Planned work. We expect to get to it "soon".
labels
Apr 26, 2022
Closed with brave/brave-core#13209 |
Verification
|
Verified
|
Brave | 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64) |
---|---|
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3} |
OS | macOS Version 12.5 (Build 21G5037d) |
Steps:
- installed
1.41.47
- launched Brave
- opened
brave://settings/shields
- looked at the
Shields
section
Confirmed Look & feel
heading text is removed
1.41.47 |
1.39.120 |
---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
OS/Desktop
OS/Windows
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
release-notes/exclude
Description
Look & feel
text should be removed frombrave://settings/shields
Steps to Reproduce
brave://settings/shields
Actual result:
Look & feel
text is still displayed/retained from Shields V1Expected result:
Look & feel
text should be removed.Reproduces how often:
Easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: