Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Look & feel" text should be removed from Shields global settings page #13058

Closed
wants to merge 2 commits into from
Closed

Conversation

TheAresjej
Copy link

Resolves #22382

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

"Look & feel" text should be removed from Shields global settings page #22382
@TheAresjej TheAresjej changed the title Fix #22382 Fix: "Look & feel" text should be removed from Shields global settings page Apr 19, 2022
@simonhong simonhong self-requested a review April 19, 2022 04:25
@simonhong
Copy link
Member

@TheAresjej Let's delete Look & Feel string also from brave_generated_resources.grd as it's not used anymore.
and can you attach screenshot of updated shields settings page?

@TheAresjej
Copy link
Author

Let's delete Look & Feel string also from brave_generated_resources.grd as it's not used anymore. and can you attach screenshot of updated shields settings page?

@simonhong I've made the correction, but so far I'm not quite sure how I can make this screenshot 😅

@simonhong
Copy link
Member

simonhong commented Apr 20, 2022

Let's delete Look & Feel string also from brave_generated_resources.grd as it's not used anymore. and can you attach screenshot of updated shields settings page?

@simonhong I've made the correction, but so far I'm not quite sure how I can make this screenshot 😅

I think you can use any screen capture tool based on your OS. (ex, cmd+shift+4 on macOS)
I wanna see proper separator line is rendered after deleting Look & Feel. It should have divider after deleting.
Screen Shot 2022-04-20 at 10 00 50 AM
and I think you have something more. I assume this PR has build failure :)

@TheAresjej TheAresjej closed this May 2, 2022
@TheAresjej TheAresjej deleted the patch-1 branch May 2, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Look & feel" text should be removed from Shields global settings page
2 participants