Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Common Library: Ads confirmations #2241

Closed
mandar-brave opened this issue Nov 26, 2018 · 2 comments
Closed

(Feature) Common Library: Ads confirmations #2241

mandar-brave opened this issue Nov 26, 2018 · 2 comments
Assignees
@mandar-brave
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release.
Milestone
0.63.x - Release ...

Comments

@mandar-brave
Copy link

Develop a common library for Core and Android to support;

  • ad catalog json pulled from ad-server
  • ad confirmations
  • ad payments integration into bat-wallet

Please close issues:
https://github.com/brave-intl/bat-client-issues/issues/1
https://github.com/brave-intl/bat-client-issues/issues/5

cc @mrose17 @kevinlawler @NejcZdovc
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages labels Dec 4, 2018
@mandar-brave mandar-brave added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 17, 2018
@NejcZdovc NejcZdovc removed the about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages label Dec 17, 2018
@tmancey
Copy link
Contributor

tmancey commented Feb 1, 2019 •
edited
Loading

Resolved as part ofhttps://github.com//issues/3117 which is currently in peer review

@tmancey tmancey assigned mandar-brave and unassigned tmancey Feb 5, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@tmancey
Copy link
Contributor

tmancey commented Feb 27, 2019

agreed with @mandar-brave that this ticket can be closed as this issue has been resolved with bat-native-ads and bat-native-confirmations repos

@tmancey tmancey closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandar-brave mandar-brave

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @tmancey @rebron @NejcZdovc @mandar-brave