Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmations implementation #3117

Closed
tmancey opened this issue Jan 26, 2019 · 3 comments · Fixed by brave/brave-core#1645 or #3406
Closed

Confirmations implementation #3117

tmancey opened this issue Jan 26, 2019 · 3 comments · Fixed by brave/brave-core#1645 or #3406

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 26, 2019

Implement Confirmations into Brave Core

@bsclifton
Copy link
Member

@tmancey can you add a test plan in here? (or in the PR- and then link to it from the top post)

@tmancey
Copy link
Contributor Author

tmancey commented Apr 15, 2019

@LaurenWags
Copy link
Member

LaurenWags commented Apr 19, 2019

Verified passed with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment